[GitHub] [shardingsphere] taojintianxia opened a new pull request, #21677: Refactor : integrate the different build job together

[GitBox <gi...@apache.org>]

taojintianxia opened a new pull request, #21677:
URL: https://github.com/apache/shardingsphere/pull/21677

   Changes proposed in this pull request:
     - integrate the different build job together
     - upgrade the docker login action
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #21677: Refactor : integrate the different build job together

[GitBox <gi...@apache.org>]

zhaojinchao95 merged PR #21677:
URL: https://github.com/apache/shardingsphere/pull/21677


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #21677: Refactor : integrate the different build job together

[GitBox <gi...@apache.org>]

linghengqian commented on code in PR #21677:
URL: https://github.com/apache/shardingsphere/pull/21677#discussion_r1001524526


##########
.github/workflows/nightly-build.yml:
##########
@@ -88,3 +89,32 @@ jobs:
       - uses: docker/setup-buildx-action@v1
       - name: Push docker image
         run: ./mvnw -am -pl distribution/proxy -B -Prelease,docker.buildx.push -DskipTests -Dproxy.image.repository=${{ env.PROXY }} -Dproxy.image.tag=${{ github.sha }} clean install
+
+  build-proxy-native-image:
+    if: github.repository == 'apache/shardingsphere'
+    timeout-minutes: 90
+    permissions:
+      contents: read
+      packages: write
+    name: GraalVM Native Image on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+      fail-fast: false
+    steps:
+      - uses: actions/checkout@v3
+      - uses: graalvm/setup-graalvm@v1
+        with:
+          version: 'releases'

Review Comment:
   - I just wanted to ask, `graalvm/setup-graalvm@v1` doesn't seem to have this keyword?  `version` only has `latest`, `dev`, or specifies a version like `22.2.0`.  Reference https://github.com/graalvm/setup-graalvm . 👀



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org