You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by "cdmikechen (via GitHub)" <gi...@apache.org> on 2023/04/30 07:27:05 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #1063: SUBMARINE-1380. Modification of the Naming Convention for subamrine-sdk dev
cdmikechen opened a new pull request, #1063:
URL: https://github.com/apache/submarine/pull/1063
### What is this PR for?
Use [pep-440](https://peps.python.org/pep-0440/) to rename the python-sdk version in order to prevent exceptions when building images and compiling.
### What type of PR is it?
Improvement
### Todos
* [x] - Update setuptools to latest version
* [x] - rename 0.8.0-SNAPSHOT to 0.8.0.dev
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1380
### How should this be tested?
CICD
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #1063: SUBMARINE-1380. Change the subamrine-sdk naming convention from SNAPSHOT to dev
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1063: SUBMARINE-1380. Change the subamrine-sdk naming convention from SNAPSHOT to dev
URL: https://github.com/apache/submarine/pull/1063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #1063: SUBMARINE-1380. Modification of the Naming Convention for subamrine-sdk dev
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1063:
URL: https://github.com/apache/submarine/pull/1063#issuecomment-1528959782
## [Codecov](https://codecov.io/gh/apache/submarine/pull/1063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1063](https://codecov.io/gh/apache/submarine/pull/1063?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (107410a) into [master](https://codecov.io/gh/apache/submarine/commit/b2e65c7d0efbfac1ba96051d8f8f7c967b07917a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2e65c7) will **decrease** coverage by `23.50%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1063 +/- ##
===========================================
- Coverage 75.98% 52.48% -23.51%
===========================================
Files 119 119
Lines 5000 5000
===========================================
- Hits 3799 2624 -1175
- Misses 1201 2376 +1175
```
| Flag | Coverage Δ | |
|---|---|---|
| python-integration | `?` | |
| python-unit | `52.48% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 33 files with indirect coverage changes](https://codecov.io/gh/apache/submarine/pull/1063/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org