You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/05/11 16:23:44 UTC
[kudu-CR](branch-1.7.x) KUDU-2346: Fix mac pkg-config issue.
Hello Alexey Serbin, Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10373
to review the following change.
Change subject: KUDU-2346: Fix mac pkg-config issue.
......................................................................
KUDU-2346: Fix mac pkg-config issue.
Previously an empty return string from pkg-config --cflags was used
as a proxy for testing if the package was installed. The MacOs version
of pkg-config returns an error message in response to this command
when a package is not installed.
The fix is to property test the return value of pkg-config --cflags.
Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Reviewed-on: http://gerrit.cloudera.org:8080/9652
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 9f6b7f16828250a89e0e331026eeb05687c6eeab)
---
M thirdparty/build-thirdparty.sh
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/10373/1
--
To view, visit http://gerrit.cloudera.org:8080/10373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Gerrit-Change-Number: 10373
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: tigerquoll@outlook.com
[kudu-CR](branch-1.7.x) KUDU-2346: Fix mac pkg-config issue.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10373 )
Change subject: KUDU-2346: Fix mac pkg-config issue.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Gerrit-Change-Number: 10373
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: tigerquoll@outlook.com
Gerrit-Comment-Date: Fri, 11 May 2018 17:16:00 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) KUDU-2346: Fix mac pkg-config issue.
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello tigerquoll@outlook.com, Alexey Serbin, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10373
to look at the new patch set (#2).
Change subject: KUDU-2346: Fix mac pkg-config issue.
......................................................................
KUDU-2346: Fix mac pkg-config issue.
Previously an empty return string from pkg-config --cflags was used
as a proxy for testing if the package was installed. The MacOs version
of pkg-config returns an error message in response to this command
when a package is not installed.
The fix is to property test the return value of pkg-config --cflags.
Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Reviewed-on: http://gerrit.cloudera.org:8080/9652
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 9f6b7f16828250a89e0e331026eeb05687c6eeab)
---
M thirdparty/build-thirdparty.sh
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/10373/2
--
To view, visit http://gerrit.cloudera.org:8080/10373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Gerrit-Change-Number: 10373
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: tigerquoll@outlook.com
[kudu-CR](branch-1.7.x) KUDU-2346: Fix mac pkg-config issue.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10373 )
Change subject: KUDU-2346: Fix mac pkg-config issue.
......................................................................
KUDU-2346: Fix mac pkg-config issue.
Previously an empty return string from pkg-config --cflags was used
as a proxy for testing if the package was installed. The MacOs version
of pkg-config returns an error message in response to this command
when a package is not installed.
The fix is to property test the return value of pkg-config --cflags.
Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Reviewed-on: http://gerrit.cloudera.org:8080/9652
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 9f6b7f16828250a89e0e331026eeb05687c6eeab)
Reviewed-on: http://gerrit.cloudera.org:8080/10373
Tested-by: Kudu Jenkins
---
M thirdparty/build-thirdparty.sh
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Gerrit-Change-Number: 10373
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: tigerquoll@outlook.com