You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2014/12/01 19:56:20 UTC

Re: Review Request 28481: Patch for KAFKA-1792

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28481/#review63409
-----------------------------------------------------------



core/src/main/scala/kafka/admin/AdminUtils.scala
<https://reviews.apache.org/r/28481/#comment105663>

    Will help to clarify that this groups the reassignment by partition.



core/src/main/scala/kafka/admin/AdminUtils.scala
<https://reviews.apache.org/r/28481/#comment105662>

    It will help to document the algorithm with examples in detail here. Makes it much easier to understand the code



core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
<https://reviews.apache.org/r/28481/#comment105664>

    Shouldn't we get rid of the 2 ways of generating reassignments?


- Neha Narkhede


On Nov. 26, 2014, 9:09 p.m., Dmitry Pekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28481/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2014, 9:09 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1792
>     https://issues.apache.org/jira/browse/KAFKA-1792
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1792: change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala 28b12c7b89a56c113b665fbde1b95f873f8624a3 
>   core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 979992b68af3723cd229845faff81c641123bb88 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala e28979827110dfbbb92fe5b152e7f1cc973de400 
>   topics.json ff011ed381e781b9a177036001d44dca3eac586f 
> 
> Diff: https://reviews.apache.org/r/28481/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Pekar
> 
>