[GitHub] bdesert commented on a change in pull request #3250: NIFI-5937 use processor-configured encoding instead of the system default

[GitBox <gi...@apache.org>]

bdesert commented on a change in pull request #3250: NIFI-5937 use processor-configured encoding instead of the system default
URL: https://github.com/apache/nifi/pull/3250#discussion_r246092495
 
 

 ##########
 File path: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java
 ##########
 @@ -345,7 +348,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
                 writeRecord(record, record.getSchema(), generator);
                 generator.flush();
                 generator.close();
-                json.append(out.toString());
+                json.append(out.toString(charset.name()));
 
 Review comment:
   I agree with implementation. Also it will make this processor consistent with PuElasticsearchHttp one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services