You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/18 03:17:49 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #27942: [SPARK-27946][SQL] Revise error message for SHOW CREATE TABLE

cloud-fan commented on a change in pull request #27942: [SPARK-27946][SQL] Revise error message for SHOW CREATE TABLE 
URL: https://github.com/apache/spark/pull/27942#discussion_r394085060
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
 ##########
 @@ -1110,7 +1110,9 @@ case class ShowCreateTableCommand(table: TableIdentifier)
         }
 
         if (tableMetadata.tableType == VIEW) {
-          throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
+          throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE. " +
 
 Review comment:
   Ideally, view is not table so SHOW CREATE TABLE should not work for views. If we don't want to add a SHOW CREATE VIEW and just want to support view in SHOW CREATE TABLE, then I think it's better to not require the AS SERDE.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org