You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/04 19:01:28 UTC
[GitHub] [airflow] michaelmicheal opened a new pull request, #28736: css, cap dropdown menu size dynamically
michaelmicheal opened a new pull request, #28736:
URL: https://github.com/apache/airflow/pull/28736
In this PR: https://github.com/apache/airflow/pull/28561, I capped the dropdown menu size to 300px and made it scrollable past there. Instead, we should cap it at 85%.
<img width="1506" alt="Screen Shot 2023-01-04 at 1 56 38 PM" src="https://user-images.githubusercontent.com/40223998/210629721-3b8782fb-caac-4e25-aee2-c9ad9a7fcb16.png">
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #28736: css, cap dropdown menu size dynamically
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #28736:
URL: https://github.com/apache/airflow/pull/28736#issuecomment-1371821775
Would it be a good idea to use `min` here? 75vh can be quite long in some situations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] j-martin commented on pull request #28736: css, cap dropdown menu size dynamically
Posted by GitBox <gi...@apache.org>.
j-martin commented on PR #28736:
URL: https://github.com/apache/airflow/pull/28736#issuecomment-1371859134
In this case, the `85vh` is only ever reached if the menu items count is significant enough. Prior to https://github.com/apache/airflow/pull/28561, the menu could be much longer than the browser viewport (so `> 100vh`). With this in mind the change here is better than the current behavior.
If I interpret your suggestion properly we'd have something like `min(85vh, 500px)`. As a users, I would rather have `85vh` so I can see all the menu items if they fit in my viewport.
For context, we programmatically generate menu items to different projects (dag bags) and there can be a lot of them:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28736: css, cap dropdown menu size dynamically
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28736:
URL: https://github.com/apache/airflow/pull/28736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org