You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/10 12:31:44 UTC

[GitHub] [netbeans] sdedic opened a new pull request #2531: Prevent endless restarts when changing JDKs.

sdedic opened a new pull request #2531:
URL: https://github.com/apache/netbeans/pull/2531


   When changing JDKs using GraalVM's extension UI, the vscode kills Apache Language Server (ALS), but then the ALS extensions notices that the channel to ALS broke and restarts it again ... killing the instance. The channel closes again etc etc.
   
   This patch should prevent restarts if the process was killed *because of* a deliberate restart.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2531: [NETBEANS-5007] Prevent endless restarts when changing JDKs.

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2531:
URL: https://github.com/apache/netbeans/pull/2531


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on pull request #2531: Prevent endless restarts when changing JDKs.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2531:
URL: https://github.com/apache/netbeans/pull/2531#issuecomment-724688690


   Testing of [12.2-rc1 build of VSCode extension](https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/173/) revealed unwanted number of restarts as @sdedic describes. The fix is essential for proper behavior of the VSCode extension when one updates `netbeans.jdkhome` property.
   
   The fix is in TypeScript part of the extension - e.g. it doesn't influence the behavior of NetBeans IDE at all - can we get the fix into release 12.2 source code without requiring retesting of NetBeans IDE 12.2-rc1, @lkishalmi?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2531: Prevent endless restarts when changing JDKs.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2531:
URL: https://github.com/apache/netbeans/pull/2531#issuecomment-724787698


   The way to get it into 12.2 is the following. Create a blocker issue in JIRA, also post it on the dev mailing list. I need to cut an rc2 probably without affecting the target date.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists