You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Emilian Bold <em...@protonmail.ch.INVALID> on 2018/07/07 19:24:43 UTC
Review commits for 9.0 Start Page
Hello,
For expedience I pushed two commits for the welcome/ module (ie. the Start Page):
* https://github.com/apache/incubator-netbeans/commit/e24634c2271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo and link in the lower-right corner
* https://github.com/apache/incubator-netbeans/commit/b787422c1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics from the splash screen and a new header background.
The end result is: https://imgur.com/a/a2FX5vD
Unless there is something wrong with these commits or somebody vetoes them, I will make another vote candidate including them.
--emi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Review commits for 9.0 Start Page
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold <
emilian.bold@protonmail.ch.invalid> wrote:
>
>
> Still, it might take some time to do this and we probably have to involve
> Antonio too for the website. This delays the next voting candidate.
>
+1 agree, let's leave it for now, good to have this list anyway and we can
work on it for the release after this one.
Gj
>
> > > Maybe, if it makes sense, while you're at it, include the PR about Ant
> > > version by Simon Ijskes (https://issues.apache.org/
> > > jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> > > done on his end and in that case we should include it in the next
> release.
>
> I will also add this. We were waiting on Simon to fix the way my own patch
> was imported in his branch. Might be simpler to add Simon's patch to my
> branch and merge that.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 7 July 2018 10:29 PM, Geertjan Wielenga <ge...@googlemail.com.INVALID>
> wrote:
>
> > Something else -- maybe, since you're making changes in the Welcome
> module,
> >
> > search for all hardcoded URLs, i.e., a lot of them are not hardcoded and
> >
> > are parsed from an XML file. But, if any are hardcoded, we might want to
> >
> > point those to somewhere on netbeans.apache.org instead.
> >
> > Gj
> >
> > On Sat, Jul 7, 2018 at 9:28 PM, Geertjan Wielenga <
> >
> > geertjan.wielenga@googlemail.com> wrote:
> >
> > > That is brilliant, really fantastic and awesome. Makes such a
> difference
> > >
> > > in terms of first impression.
> > >
> > > Maybe, if it makes sense, while you're at it, include the PR about Ant
> > >
> > > version by Simon Ijskes (https://issues.apache.org/
> > >
> > > jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> > >
> > > done on his end and in that case we should include it in the next
> release.
> > >
> > > Gj
> > >
> > > On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold
> emilian.bold@protonmail.ch
> > >
> > > wrote:
> > >
> > > > Hello,
> > > >
> > > > For expedience I pushed two commits for the welcome/ module (ie. the
> > > >
> > > > Start Page):
> > > >
> > > > - https://github.com/apache/incubator-netbeans/commit/e24634c2
> > > >
> > > > 271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo
> and link
> > > >
> > > > in the lower-right corner
> > > >
> > > > - https://github.com/apache/incubator-netbeans/commit/b787422c
> > > >
> > > > 1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics
> from the
> > > >
> > > > splash screen and a new header background.
> > > >
> > > >
> > > > The end result is: https://imgur.com/a/a2FX5vD
> > > >
> > > > Unless there is something wrong with these commits or somebody vetoes
> > > >
> > > > them, I will make another vote candidate including them.
> > > >
> > > > --emi
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: Review commits for 9.0 Start Page
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Great.
Gj
On Sat, Jul 7, 2018 at 10:03 PM, Emilian Bold <em...@protonmail.ch>
wrote:
> Check out https://github.com/apache/incubator-netbeans/pull/628 , we can
> merge into release90.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 7 July 2018 11:00 PM, Geertjan Wielenga <ge...@googlemail.com.INVALID>
> wrote:
>
> > On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold <
> >
> > emilian.bold@protonmail.ch.invalid> wrote:
> >
> > > I will also add this. We were waiting on Simon to fix the way my own
> patch
> > >
> > > was imported in his branch. Might be simpler to add Simon's patch to my
> > >
> > > branch and merge that.
> >
> > Nice.
> >
> > The 9.0 vc3 is going to be great.
> >
> > Gj
> >
> > > --emi
> > >
> > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > >
> > > On 7 July 2018 10:29 PM, Geertjan Wielenga
> geertjan.wielenga@googlemail.com.INVALID
> > >
> > > wrote:
> > >
> > > > Something else -- maybe, since you're making changes in the Welcome
> > > >
> > > > module,
> > > >
> > > > search for all hardcoded URLs, i.e., a lot of them are not hardcoded
> and
> > > >
> > > > are parsed from an XML file. But, if any are hardcoded, we might
> want to
> > > >
> > > > point those to somewhere on netbeans.apache.org instead.
> > > >
> > > > Gj
> > > >
> > > > On Sat, Jul 7, 2018 at 9:28 PM, Geertjan Wielenga <
> > > >
> > > > geertjan.wielenga@googlemail.com> wrote:
> > > >
> > > > > That is brilliant, really fantastic and awesome. Makes such a
> > > > >
> > > > > difference
> > > >
> > > > > in terms of first impression.
> > > > >
> > > > > Maybe, if it makes sense, while you're at it, include the PR about
> Ant
> > > > >
> > > > > version by Simon Ijskes (https://issues.apache.org/
> > > > >
> > > > > jira/browse/NETBEANS-781) unless there's a lot of work that needs
> to be
> > > > >
> > > > > done on his end and in that case we should include it in the next
> > > > >
> > > > > release.
> > > >
> > > > > Gj
> > > > >
> > > > > On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold
> > > > >
> > > > > emilian.bold@protonmail.ch
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hello,
> > > > > >
> > > > > > For expedience I pushed two commits for the welcome/ module (ie.
> the
> > > > > >
> > > > > > Start Page):
> > > > > >
> > > > > > - https://github.com/apache/incubator-netbeans/commit/e24634c2
> > > > > >
> > > > > > 271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator
> logo
> > > > > >
> > > > > > and link
> > > > > >
> > > >
> > > > > > in the lower-right corner
> > > > > >
> > > > > >
> > > > > > - https://github.com/apache/incubator-netbeans/commit/b787422c
> > > > > >
> > > > > > 1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics
> > > > > >
> > > > > > from the
> > > > > >
> > > >
> > > > > > splash screen and a new header background.
> > > > > >
> > > > > >
> > > > > > The end result is: https://imgur.com/a/a2FX5vD
> > > > > >
> > > > > > Unless there is something wrong with these commits or somebody
> vetoes
> > > > > >
> > > > > > them, I will make another vote candidate including them.
> > > > > >
> > > > > > --emi
> > >
> > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > For additional commands, e-mail: dev-help@netbeans.incubator.
> apache.org
> > >
> > > For further information about the NetBeans mailing lists, visit:
> > >
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
Re: Review commits for 9.0 Start Page
Posted by Emilian Bold <em...@protonmail.ch.INVALID>.
Check out https://github.com/apache/incubator-netbeans/pull/628 , we can merge into release90.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 7 July 2018 11:00 PM, Geertjan Wielenga <ge...@googlemail.com.INVALID> wrote:
> On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold <
>
> emilian.bold@protonmail.ch.invalid> wrote:
>
> > I will also add this. We were waiting on Simon to fix the way my own patch
> >
> > was imported in his branch. Might be simpler to add Simon's patch to my
> >
> > branch and merge that.
>
> Nice.
>
> The 9.0 vc3 is going to be great.
>
> Gj
>
> > --emi
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On 7 July 2018 10:29 PM, Geertjan Wielenga geertjan.wielenga@googlemail.com.INVALID
> >
> > wrote:
> >
> > > Something else -- maybe, since you're making changes in the Welcome
> > >
> > > module,
> > >
> > > search for all hardcoded URLs, i.e., a lot of them are not hardcoded and
> > >
> > > are parsed from an XML file. But, if any are hardcoded, we might want to
> > >
> > > point those to somewhere on netbeans.apache.org instead.
> > >
> > > Gj
> > >
> > > On Sat, Jul 7, 2018 at 9:28 PM, Geertjan Wielenga <
> > >
> > > geertjan.wielenga@googlemail.com> wrote:
> > >
> > > > That is brilliant, really fantastic and awesome. Makes such a
> > > >
> > > > difference
> > >
> > > > in terms of first impression.
> > > >
> > > > Maybe, if it makes sense, while you're at it, include the PR about Ant
> > > >
> > > > version by Simon Ijskes (https://issues.apache.org/
> > > >
> > > > jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> > > >
> > > > done on his end and in that case we should include it in the next
> > > >
> > > > release.
> > >
> > > > Gj
> > > >
> > > > On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold
> > > >
> > > > emilian.bold@protonmail.ch
> > >
> > > > wrote:
> > > >
> > > > > Hello,
> > > > >
> > > > > For expedience I pushed two commits for the welcome/ module (ie. the
> > > > >
> > > > > Start Page):
> > > > >
> > > > > - https://github.com/apache/incubator-netbeans/commit/e24634c2
> > > > >
> > > > > 271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo
> > > > >
> > > > > and link
> > > > >
> > >
> > > > > in the lower-right corner
> > > > >
> > > > >
> > > > > - https://github.com/apache/incubator-netbeans/commit/b787422c
> > > > >
> > > > > 1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics
> > > > >
> > > > > from the
> > > > >
> > >
> > > > > splash screen and a new header background.
> > > > >
> > > > >
> > > > > The end result is: https://imgur.com/a/a2FX5vD
> > > > >
> > > > > Unless there is something wrong with these commits or somebody vetoes
> > > > >
> > > > > them, I will make another vote candidate including them.
> > > > >
> > > > > --emi
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Review commits for 9.0 Start Page
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold <
emilian.bold@protonmail.ch.invalid> wrote:
>
>
> I will also add this. We were waiting on Simon to fix the way my own patch
> was imported in his branch. Might be simpler to add Simon's patch to my
> branch and merge that.
>
Nice.
The 9.0 vc3 is going to be great.
Gj
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 7 July 2018 10:29 PM, Geertjan Wielenga <ge...@googlemail.com.INVALID>
> wrote:
>
> > Something else -- maybe, since you're making changes in the Welcome
> module,
> >
> > search for all hardcoded URLs, i.e., a lot of them are not hardcoded and
> >
> > are parsed from an XML file. But, if any are hardcoded, we might want to
> >
> > point those to somewhere on netbeans.apache.org instead.
> >
> > Gj
> >
> > On Sat, Jul 7, 2018 at 9:28 PM, Geertjan Wielenga <
> >
> > geertjan.wielenga@googlemail.com> wrote:
> >
> > > That is brilliant, really fantastic and awesome. Makes such a
> difference
> > >
> > > in terms of first impression.
> > >
> > > Maybe, if it makes sense, while you're at it, include the PR about Ant
> > >
> > > version by Simon Ijskes (https://issues.apache.org/
> > >
> > > jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> > >
> > > done on his end and in that case we should include it in the next
> release.
> > >
> > > Gj
> > >
> > > On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold
> emilian.bold@protonmail.ch
> > >
> > > wrote:
> > >
> > > > Hello,
> > > >
> > > > For expedience I pushed two commits for the welcome/ module (ie. the
> > > >
> > > > Start Page):
> > > >
> > > > - https://github.com/apache/incubator-netbeans/commit/e24634c2
> > > >
> > > > 271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo
> and link
> > > >
> > > > in the lower-right corner
> > > >
> > > > - https://github.com/apache/incubator-netbeans/commit/b787422c
> > > >
> > > > 1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics
> from the
> > > >
> > > > splash screen and a new header background.
> > > >
> > > >
> > > > The end result is: https://imgur.com/a/a2FX5vD
> > > >
> > > > Unless there is something wrong with these commits or somebody vetoes
> > > >
> > > > them, I will make another vote candidate including them.
> > > >
> > > > --emi
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: Review commits for 9.0 Start Page
Posted by Emilian Bold <em...@protonmail.ch.INVALID>.
The URLs are:
URL_MoreTutorials=http://netbeans.org/kb/index.html?utm_source=netbeans&utm_campaign=welcomepage
URL_Blogs=http://planetnetbeans.org/rss20.xml
URL_ArticlesAndNews=http://www.netbeans.org/mtmo.xml
URL_News=http://www.netbeans.org/news.xml
URL_AllNews=http://netbeans.org/community/news/index.html?utm_source=netbeans&utm_campaign=welcomepage
URL_AllArticles=http://netbeans.org/kb/kb.html?utm_source=netbeans&utm_campaign=welcomepage
URL_AllBlogs=http://planetnetbeans.org?utm_source=netbeans&utm_campaign=welcomepage
URL_AllOnlineDocs=http://netbeans.org/kb?utm_source=netbeans&utm_campaign=welcomepage
URL_SectionDemosAndTutorials=http://netbeans.org/kb?utm_source=netbeans&utm_campaign=welcomepage
URL_Demo=http://www.netbeans.org/demos.xml
I see there are some duplicates but I don't know what to replace each with.
The simplest would be to create netbeans.apache.org dummy pages for all of them and just redirect to the existing links on netbeans.org. In time we will provide our own content straight from netbeans.apache.org
Still, it might take some time to do this and we probably have to involve Antonio too for the website. This delays the next voting candidate.
> > Maybe, if it makes sense, while you're at it, include the PR about Ant
> > version by Simon Ijskes (https://issues.apache.org/
> > jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> > done on his end and in that case we should include it in the next release.
I will also add this. We were waiting on Simon to fix the way my own patch was imported in his branch. Might be simpler to add Simon's patch to my branch and merge that.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 7 July 2018 10:29 PM, Geertjan Wielenga <ge...@googlemail.com.INVALID> wrote:
> Something else -- maybe, since you're making changes in the Welcome module,
>
> search for all hardcoded URLs, i.e., a lot of them are not hardcoded and
>
> are parsed from an XML file. But, if any are hardcoded, we might want to
>
> point those to somewhere on netbeans.apache.org instead.
>
> Gj
>
> On Sat, Jul 7, 2018 at 9:28 PM, Geertjan Wielenga <
>
> geertjan.wielenga@googlemail.com> wrote:
>
> > That is brilliant, really fantastic and awesome. Makes such a difference
> >
> > in terms of first impression.
> >
> > Maybe, if it makes sense, while you're at it, include the PR about Ant
> >
> > version by Simon Ijskes (https://issues.apache.org/
> >
> > jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> >
> > done on his end and in that case we should include it in the next release.
> >
> > Gj
> >
> > On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold emilian.bold@protonmail.ch
> >
> > wrote:
> >
> > > Hello,
> > >
> > > For expedience I pushed two commits for the welcome/ module (ie. the
> > >
> > > Start Page):
> > >
> > > - https://github.com/apache/incubator-netbeans/commit/e24634c2
> > >
> > > 271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo and link
> > >
> > > in the lower-right corner
> > >
> > > - https://github.com/apache/incubator-netbeans/commit/b787422c
> > >
> > > 1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics from the
> > >
> > > splash screen and a new header background.
> > >
> > >
> > > The end result is: https://imgur.com/a/a2FX5vD
> > >
> > > Unless there is something wrong with these commits or somebody vetoes
> > >
> > > them, I will make another vote candidate including them.
> > >
> > > --emi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: Review commits for 9.0 Start Page
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Something else -- maybe, since you're making changes in the Welcome module,
search for all hardcoded URLs, i.e., a lot of them are not hardcoded and
are parsed from an XML file. But, if any are hardcoded, we might want to
point those to somewhere on netbeans.apache.org instead.
Gj
On Sat, Jul 7, 2018 at 9:28 PM, Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:
> That is brilliant, really fantastic and awesome. Makes such a difference
> in terms of first impression.
>
> Maybe, if it makes sense, while you're at it, include the PR about Ant
> version by Simon Ijskes (https://issues.apache.org/
> jira/browse/NETBEANS-781) unless there's a lot of work that needs to be
> done on his end and in that case we should include it in the next release.
>
> Gj
>
>
>
> On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold <em...@protonmail.ch>
> wrote:
>
>> Hello,
>>
>> For expedience I pushed two commits for the welcome/ module (ie. the
>> Start Page):
>>
>> * https://github.com/apache/incubator-netbeans/commit/e24634c2
>> 271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo and link
>> in the lower-right corner
>>
>> * https://github.com/apache/incubator-netbeans/commit/b787422c
>> 1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics from the
>> splash screen and a new header background.
>>
>> The end result is: https://imgur.com/a/a2FX5vD
>>
>> Unless there is something wrong with these commits or somebody vetoes
>> them, I will make another vote candidate including them.
>>
>> --emi
>>
>
>
Re: Review commits for 9.0 Start Page
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
That is brilliant, really fantastic and awesome. Makes such a difference in
terms of first impression.
Maybe, if it makes sense, while you're at it, include the PR about Ant
version by Simon Ijskes (https://issues.apache.org/jira/browse/NETBEANS-781)
unless there's a lot of work that needs to be done on his end and in that
case we should include it in the next release.
Gj
On Sat, Jul 7, 2018 at 9:24 PM, Emilian Bold <em...@protonmail.ch>
wrote:
> Hello,
>
> For expedience I pushed two commits for the welcome/ module (ie. the Start
> Page):
>
> * https://github.com/apache/incubator-netbeans/commit/
> e24634c2271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo
> and link in the lower-right corner
>
> * https://github.com/apache/incubator-netbeans/commit/
> b787422c1eaec12e0f589d5ac38ad3aa24ee31d4 adds some new tab graphics from
> the splash screen and a new header background.
>
> The end result is: https://imgur.com/a/a2FX5vD
>
> Unless there is something wrong with these commits or somebody vetoes
> them, I will make another vote candidate including them.
>
> --emi
>