You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/19 04:02:43 UTC
[GitHub] [druid] suneet-s opened a new pull request, #12457: Promote stats-d emitter to a core extension
suneet-s opened a new pull request, #12457:
URL: https://github.com/apache/druid/pull/12457
### Description
Move the stats-d emitter to a core extension.
AFAICT we are using the latest version of the java client https://github.com/DataDog/java-dogstatsd-client/releases/tag/v4.0.0
I have tried running this extension in a cluster and haven't noticed any issues. I did notice that not all metrics are reported in the default configuration. I've added 2 more metrics to be reported by default `coordinator/global/time` and `coordinator/time` as these are helpful in knowing how long different coordinator duties are taking.
I had considered a system to automatically detect when a new metric was reported so that we don't forget to update the config of this emitter when a new metric is added, however, I could not think of a reliable way to do this, so I decided to leave it out of the change that promotes this extension to a core extension.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #12457: Promote stats-d emitter to a core extension
Posted by GitBox <gi...@apache.org>.
clintropolis commented on PR #12457:
URL: https://github.com/apache/druid/pull/12457#issuecomment-1103220632
>I had considered a system to automatically detect when a new metric was reported so that we don't forget to update the config of this emitter when a new metric is added, however, I could not think of a reliable way to do this, so I decided to leave it out of the change that promotes this extension to a core extension.
related #11958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on pull request #12457: Promote stats-d emitter to a core extension
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on PR #12457:
URL: https://github.com/apache/druid/pull/12457#issuecomment-1103437116
Should the group id of this extension be changed from `org.apache.druid.extensions.contrib` to `org.apache.druid.extensions` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #12457: Promote stats-d emitter to a core extension
Posted by GitBox <gi...@apache.org>.
clintropolis commented on PR #12457:
URL: https://github.com/apache/druid/pull/12457#issuecomment-1103274378
>How did you find these links? Is there a test already for stuff like this?
Heh good question, something like a spidey sense I guess after I pressed approve if there were any sneaky things to consider.
>Is there a test already for stuff like this?
Sidebars isn't really testable because its controlling which things should be shown/hidden on the docs page nav sidebar, so is subjective. Spelling exceptions are not checked that the page they are referring to exists (though i'm unsure why we don't have just a giant exception list instead of that + per page exceptions...). Redirects could possibly be checked if we detect a diff that moves a doc page, but is currently not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #12457: Promote stats-d emitter to a core extension
Posted by GitBox <gi...@apache.org>.
suneet-s commented on PR #12457:
URL: https://github.com/apache/druid/pull/12457#issuecomment-1103276605
glad your spidey senses kicked in 😅 I'll push up another patch with those fixes as soon as I get this license check job to pass locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Promote stats-d emitter to a core extension (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12457: Promote stats-d emitter to a core extension
URL: https://github.com/apache/druid/pull/12457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #12457: Promote stats-d emitter to a core extension
Posted by GitBox <gi...@apache.org>.
suneet-s commented on PR #12457:
URL: https://github.com/apache/druid/pull/12457#issuecomment-1103233043
> oh a couple more things need fixing, https://github.com/apache/druid/blob/master/website/sidebars.json#L282 https://github.com/apache/druid/blob/master/website/.spelling#L721
>
> and also please add an entry to redirects file https://github.com/apache/druid/blob/master/website/redirects.json
How did you find these links? Is there a test already for stuff like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Promote stats-d emitter to a core extension (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12457:
URL: https://github.com/apache/druid/pull/12457#issuecomment-1854890095
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Promote stats-d emitter to a core extension (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12457:
URL: https://github.com/apache/druid/pull/12457#issuecomment-1885968667
This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org