You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2008/06/09 13:57:45 UTC
[jira] Created: (SYNAPSE-353) Is dependency on Commons Lang is
justified?
Is dependency on Commons Lang is justified?
-------------------------------------------
Key: SYNAPSE-353
URL: https://issues.apache.org/jira/browse/SYNAPSE-353
Project: Synapse
Issue Type: Wish
Components: Transports
Affects Versions: 1.2
Reporter: Oleg Kalnichevski
Priority: Minor
Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-353) Is dependency on Commons Lang
justified?
Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603621#action_12603621 ]
Ruwan Linton commented on SYNAPSE-353:
--------------------------------------
Andreas, I am in the process of building the synapse site and had generated the dependency report ;-)
It is coming as a transitive dependency from org.apache.qpid:qpid-client:jar
> Is dependency on Commons Lang justified?
> ----------------------------------------
>
> Key: SYNAPSE-353
> URL: https://issues.apache.org/jira/browse/SYNAPSE-353
> Project: Synapse
> Issue Type: Wish
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
>
> Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-353) Is dependency on Commons Lang
justified?
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603624#action_12603624 ]
Andreas Veithen commented on SYNAPSE-353:
-----------------------------------------
The problem is that the dependency report only shows each transitive dependency only once (or am I wrong here?). So we know that qpid depends on commons-lang but that doesn't mean that there are no other dependencies that rely on it.
> Is dependency on Commons Lang justified?
> ----------------------------------------
>
> Key: SYNAPSE-353
> URL: https://issues.apache.org/jira/browse/SYNAPSE-353
> Project: Synapse
> Issue Type: Wish
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
>
> Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-353) Is dependency on Commons Lang
justified?
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603617#action_12603617 ]
Andreas Veithen commented on SYNAPSE-353:
-----------------------------------------
Anybody knows which dependency causes Commons lang to be included as transitive dependency?
> Is dependency on Commons Lang justified?
> ----------------------------------------
>
> Key: SYNAPSE-353
> URL: https://issues.apache.org/jira/browse/SYNAPSE-353
> Project: Synapse
> Issue Type: Wish
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
>
> Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-353) Is dependency on Commons Lang
justified?
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated SYNAPSE-353:
--------------------------------------
Summary: Is dependency on Commons Lang justified? (was: Is dependency on Commons Lang is justified?)
> Is dependency on Commons Lang justified?
> ----------------------------------------
>
> Key: SYNAPSE-353
> URL: https://issues.apache.org/jira/browse/SYNAPSE-353
> Project: Synapse
> Issue Type: Wish
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
>
> Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-353) Is dependency on Commons Lang
justified?
Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603608#action_12603608 ]
Asankha C. Perera commented on SYNAPSE-353:
-------------------------------------------
Oleg
I totally agree with you that it will be good to not depend on Commons lang just for two methods.. I think right now it gets included as a transitive dependency. Usually before each release we generate the distribution, and manually check each JAR file to make sure if they are needed, and who uses them.. so the fewer dependencies, the better
asankha
> Is dependency on Commons Lang justified?
> ----------------------------------------
>
> Key: SYNAPSE-353
> URL: https://issues.apache.org/jira/browse/SYNAPSE-353
> Project: Synapse
> Issue Type: Wish
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
>
> Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Resolved: (SYNAPSE-353) Is dependency on Commons Lang
justified?
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved SYNAPSE-353.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.3
Fixed in SVN trunk.
Oleg
> Is dependency on Commons Lang justified?
> ----------------------------------------
>
> Key: SYNAPSE-353
> URL: https://issues.apache.org/jira/browse/SYNAPSE-353
> Project: Synapse
> Issue Type: Wish
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
>
> Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-353) Is dependency on Commons Lang
justified?
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603596#action_12603596 ]
Oleg Kalnichevski commented on SYNAPSE-353:
-------------------------------------------
Moreover, I do not even see Commons Lang declared as one of the Synapse dependencies
Oleg
> Is dependency on Commons Lang justified?
> ----------------------------------------
>
> Key: SYNAPSE-353
> URL: https://issues.apache.org/jira/browse/SYNAPSE-353
> Project: Synapse
> Issue Type: Wish
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
>
> Currently Synapse Transport uses only two methods from Commons Lang: StringUtils#leftPad and StringUtils#isNotBlank. I am not sure the benefits of reusing those two methods really justifies having an extra external dependency. Please consider decoupling Synapse Transports from Commons Lang.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org