You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/03 14:56:43 UTC

[GitHub] [tvm] tqchen commented on pull request #12140: [LLVM] Create LLVM scope object for use with LLVM libraries

tqchen commented on PR #12140:
URL: https://github.com/apache/tvm/pull/12140#issuecomment-1204060680

   Sorry for delayed reply. Approving as it is a good chunk of improvement. It would be great to discuss naming and documentation a bit.
    
   When I see LLVMScope, I was expecting LLVM to taken in-effect. But in reality, we can have multiple `LLVMScope` object, one per LLVMModule. The API kicks in when we do 
   
   ```c++
   With<LLVMTarget> target(scope, ...)
   ```
   
   So LLVMScope is not exactly an unique RAII object. Sorry that I missed it when reading the RFC but it becomes obvious when reading implementation of LLVMModule.
   
   Perhaps we should consider clarify and rename in this case.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org