You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@skywalking.apache.org by wu...@apache.org on 2018/04/25 04:04:34 UTC
[incubator-skywalking] branch hotfix/5.0.0-alpha updated: fix grpc
issue (#1039)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch hotfix/5.0.0-alpha
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/hotfix/5.0.0-alpha by this push:
new 78c8857 fix grpc issue (#1039)
78c8857 is described below
commit 78c88576236dcafb045faf785a63e76170922259
Author: Xin,Zhang <zh...@apache.org>
AuthorDate: Fri Apr 6 22:44:47 2018 +0800
fix grpc issue (#1039)
---
.../skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java b/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java
index ce74a8f..aa713e3 100644
--- a/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java
+++ b/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/BlockingCallClientInterceptor.java
@@ -75,7 +75,7 @@ public class BlockingCallClientInterceptor extends ForwardingClientCall.SimpleFo
@Override public void onClose(Status status, Metadata trailers) {
delegate().onClose(status, trailers);
- if (status.isOk()) {
+ if (!status.isOk()) {
AbstractSpan activeSpan = ContextManager.activeSpan();
activeSpan.errorOccurred().log(status.getCause());
Tags.STATUS_CODE.set(activeSpan, status.getCode().name());
--
To stop receiving notification emails like this one, please contact
wusheng@apache.org.