You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/19 02:29:21 UTC

[GitHub] [calcite] chunweilei commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

chunweilei commented on a change in pull request #2016:
URL: https://github.com/apache/calcite/pull/2016#discussion_r442598141



##########
File path: core/src/main/java/org/apache/calcite/plan/hep/HepRelVertex.java
##########
@@ -75,8 +76,8 @@
     return currentRel.getRowType();
   }
 
-  @Override protected String computeDigest() {
-    return "HepRelVertex(" + currentRel + ")";
+  @Override protected Digest computeDigest() {
+    return Digest.create(this, getRelTypeName() + '#' + getCurrentRel().getId());
   }
 

Review comment:
       Why do you use `getRelTypeName()` rathen than "HepRelVertex"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org