You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/05 08:25:10 UTC

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8459: ARROW-10195: [C++] Add string struct extract kernel using re2

maartenbreddels commented on a change in pull request #8459:
URL: https://github.com/apache/arrow/pull/8459#discussion_r517867055



##########
File path: cpp/CMakeLists.txt
##########
@@ -735,6 +735,7 @@ endif()
 
 if(ARROW_WITH_UTF8PROC)
   list(APPEND ARROW_LINK_LIBS utf8proc::utf8proc)
+  list(APPEND ARROW_LINK_LIBS re2)

Review comment:
       Not all of them need the libraries, all the ASCII kernels run without. But for simplicity, I don't think it's a bad idea. 
   
   Could it be an option that enabling ARROW_COMPUTE_STRINGS by default enables ARROW_WITH_RE2 and ARROW_WITH_UTF8PROC, but still allow you to override ARROW_WITH_RE2/ARROW_WITH_UTF8PROC. This would allow someone to build with just the ASCII kernels, or just ASCII and ARROW_WITH_UTF8PROC based kernels.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org