[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2056: TINKERPOP-2703 Build on JDK17

["spmallette (via GitHub)" <gi...@apache.org>]

spmallette commented on code in PR #2056:
URL: https://github.com/apache/tinkerpop/pull/2056#discussion_r1189064192


##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/jsr223/ScriptEngineCacheTest.java:
##########
@@ -35,6 +37,9 @@ public void shouldBeUtilityClass() throws Exception {
 
     @Test
     public void shouldGetEngineFromCache() {
+        String javaVersion = System.getProperty("java.version");

Review Comment:
   is there another way to test this that perhaps doesn't require us to use nashorn? that way we could avoid binding to a particular jdk version/type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org