You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/01/25 18:20:35 UTC

Re: Review Request 42690: Moved ExecutorInfo and Option TaskInfo into ContainerConfig.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42690/
-----------------------------------------------------------

(Updated Jan. 25, 2016, 9:20 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Bugs: MESOS-4500
    https://issues.apache.org/jira/browse/MESOS-4500


Repository: mesos


Description
-------

Moved ExecutorInfo and Option TaskInfo into ContainerConfig.


Diffs
-----

  include/mesos/slave/isolator.hpp c273d668cee1f8000d02247a04cf71573a407815 
  include/mesos/slave/isolator.proto c4b7b1f80f52b85632133e3423a89f92b0ff32f3 
  src/slave/containerizer/mesos/containerizer.hpp a8177fb4e9f503ddabf834551cb987a4f58d8961 
  src/slave/containerizer/mesos/containerizer.cpp 075b3abbe100c72da4c78c0be33ba37473fc4a23 
  src/slave/containerizer/mesos/isolator.hpp 8bdccde81d5a16506ccead917decda6f39a0abb1 
  src/slave/containerizer/mesos/isolator.cpp 4de981047cd1b995d23e0e20af841035ca689ac6 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 9c331ebcdf1a12f8587b789c96d2eb843e6894b1 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp afab0b4b7a4ab50bf68efc6938735970a59192de 
  src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 944544da762371692eadcac18bfb7334a8a5bffa 
  src/slave/containerizer/mesos/isolators/cgroups/mem.cpp bc76a0b6940f6a17f820a24ec6b2c9d8dd449c4a 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 7ce5243ed7476a1cfd1371b5ce25b62dc07432db 
  src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 0798de747627ccc45b01a2668e16693757dc69a8 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp a996b102e3cf725121a024e2eaecc0f5e1d40232 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 573621479b1d18c18a78b59d2c8c5a396595e50a 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 3acbd6904de254bd5fd405ee2cd1f33b610dfa97 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 96c37ed7ac27074eb79e3eb5e0301b642ab653f2 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp b36a196fa8e953143ec96aae7b39cba6ee1b01fa 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp d914587eedc9c66bc14b4088ec211b7f0eea63ea 
  src/slave/containerizer/mesos/isolators/filesystem/shared.hpp c3ac4488c5b1f3abe5bf59e5c9df80993c0f467d 
  src/slave/containerizer/mesos/isolators/filesystem/shared.cpp c1b6e086a85ca03acebc4844a6753ebb6cb58fc5 
  src/slave/containerizer/mesos/isolators/namespaces/pid.hpp e20b5841e355656c9be688d28af8b758fdae0b27 
  src/slave/containerizer/mesos/isolators/namespaces/pid.cpp fb21e6c6e9705118a94ee52fe66d74ee7b184376 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp ea58c42986ab2e795799bd9d193987450b766472 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp c8e5281f05a5f8c8c00adcc7b041053a7c10b5d5 
  src/slave/containerizer/mesos/isolators/posix.hpp 7cdf9ed2678e098d9c83017b8ed8ec490dc2e964 
  src/slave/containerizer/mesos/isolators/posix/disk.hpp e718a111e6c5d1120ef767a16f286162d925ba64 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 5d4381087677dae58b1fb6da0f47093a4a749d73 
  src/tests/containerizer/isolator.hpp 0f9b21aeab0a3d0facc803463b08a3259f569b8b 
  src/tests/containerizer/isolator_tests.cpp 6510553b412ae70f981949754c207fb5f7e1c220 
  src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
  src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b 

Diff: https://reviews.apache.org/r/42690/diff/


Testing
-------

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song