You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jose-torres <gi...@git.apache.org> on 2018/03/16 00:05:31 UTC
[GitHub] spark pull request #20840: [SPARK-23702][SS] Forbid watermarks on both sides...
GitHub user jose-torres opened a pull request:
https://github.com/apache/spark/pull/20840
[SPARK-23702][SS] Forbid watermarks on both sides of a streaming aggregate.
## What changes were proposed in this pull request?
Forbid watermarks on both sides of a streaming aggregate. As detailed in the jira, we don't currently support this and doing so would require significant revision to the execution model.
## How was this patch tested?
new unit test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jose-torres/spark disallowAgg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20840
----
commit 9d742ab4d22021654aa2778d601d806b7a7d106a
Author: Jose Torres <to...@...>
Date: 2018-03-16T00:03:54Z
disallow watermark on both sides
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20840: [SPARK-23702][SS] Forbid watermarks on both sides of a s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20840
**[Test build #88282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88282/testReport)** for PR 20840 at commit [`9d742ab`](https://github.com/apache/spark/commit/9d742ab4d22021654aa2778d601d806b7a7d106a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20840: [SPARK-23702][SS] Forbid watermarks on both sides of a s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20840
**[Test build #88282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88282/testReport)** for PR 20840 at commit [`9d742ab`](https://github.com/apache/spark/commit/9d742ab4d22021654aa2778d601d806b7a7d106a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20840: [SPARK-23702][SS] Forbid watermarks on both sides of a s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20840
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88282/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20840: [SPARK-23702][SS] Forbid watermarks on both sides of a s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20840
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20840: [SPARK-23702][SS] Forbid watermarks on both sides of a s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20840
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20840: [SPARK-23702][SS] Forbid watermarks on both sides...
Posted by jose-torres <gi...@git.apache.org>.
Github user jose-torres closed the pull request at:
https://github.com/apache/spark/pull/20840
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org