You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/10 00:21:38 UTC
[GitHub] [airflow] kaxil opened a new pull request #12221: Remove Unnecessary comprehension
kaxil opened a new pull request #12221:
URL: https://github.com/apache/airflow/pull/12221
The inbuilt functions all() and any() in python also support
short-circuiting (evaluation stops as soon as the overall return value
of the function is known), but this behavior is lost if you use
comprehension. This affects performance.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12221: Remove Unnecessary comprehension
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12221:
URL: https://github.com/apache/airflow/pull/12221#issuecomment-724631998
Haha :D fixed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12221: Remove Unnecessary comprehension
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12221:
URL: https://github.com/apache/airflow/pull/12221#issuecomment-724378602
[The Workflow run](https://github.com/apache/airflow/actions/runs/354995914) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12221: Remove Unnecessary comprehension
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12221:
URL: https://github.com/apache/airflow/pull/12221#issuecomment-724581426
> Static check is saying: GOTCHA
It caught you red-handed @kaxil :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12221: Remove Unnecessary comprehension
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12221:
URL: https://github.com/apache/airflow/pull/12221#issuecomment-724478451
Static check is saying: GOTCHA😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12221: Remove Unnecessary comprehension
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12221:
URL: https://github.com/apache/airflow/pull/12221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12221: Remove Unnecessary comprehension
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12221:
URL: https://github.com/apache/airflow/pull/12221#issuecomment-724656841
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org