You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/02 10:18:00 UTC
[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are
not preserved when rewriting URI
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807622#comment-16807622 ]
ASF subversion and git services commented on HTTPCLIENT-1968:
-------------------------------------------------------------
Commit acd8fcd95fcc9cb04fbddd23022e40b7eba4c2f9 in httpcomponents-client's branch refs/heads/HTTPCLIENT-1976 from Oleg Kalnichevski
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=acd8fcd ]
Merge pull request #137 from ok2c/HTTPCLIENT-1968
URIBuilder and URIUtils improvements
> Encoded forward slashes are not preserved when rewriting URI
> ------------------------------------------------------------
>
> Key: HTTPCLIENT-1968
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1968
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.5.7
> Reporter: Jay Modi
> Priority: Major
> Fix For: 4.5.8, 5.0 Beta4
>
> Attachments: rewrite_preserve_forward_slash.diff
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> URIs that contain an encoded forward slash (%2F) are no longer preserved when the HTTP client executes. I came across this when upgrading from 4.5.2 to 4.5.7 and my requests that contained an encoded forward slash suddenly started failing. The appears to be due to decoding and re-encoding of the path that takes place in the URIUtils#rewriteURI method. I've attached a patch that restores the old behavior but if a URI contains two slashes in a row in addition to an encoded slash the encoded forward slash will be decoded.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org