[jira] [Commented] (THRIFT-1847) TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file

["Chris Stylianou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710327#comment-13710327 ] 

Chris Stylianou commented on THRIFT-1847:
-----------------------------------------

Is there any possibility of this patch being accepted?
                
> TSSLSocket.cpp and TFileTransport.cpp incorrectly excluded from Visual Studio project file
> ------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1847
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1847
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: MSVC 2010 (Windows 7) and MSVC 2012 (Windows 8)
>            Reporter: Chris Stylianou
>            Priority: Minor
>              Labels: cpp, msvc, thrift
>         Attachments: thrift-msvc.patch
>
>
> Both TSSLSocket.cpp and TFileTransport.cpp are incorrectly excluded from Visual Studio project file, so they are not built. I've attached a patch to include them again.
> TSSLSocket.cpp also has an issue due to the use of 'snprintf' which is a C99 feature that isn't provided by MSVC compilers. I've also included a fix for this in the attached patch which uses '_snprintf_s' for MSVC instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira