You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/05 20:49:15 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #34496: [SPARK-37218][SQL][TEST] Parameterize shuffle partitions in TPCDSQueryBenchmark

dongjoon-hyun opened a new pull request #34496:
URL: https://github.com/apache/spark/pull/34496


   ### What changes were proposed in this pull request?
   
   This PR aims to parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark.
   
   ### Why are the changes needed?
   
   This helps a single machine benchmark with many cores.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Manually.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962210210


   **[Test build #144939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144939/testReport)** for PR 34496 at commit [`776da3e`](https://github.com/apache/spark/commit/776da3e38b36ddea32f53e940db994406b27551e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962258062


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49411/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962265027


   Thank you so much, @sunchao !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962265314


   I backported this to branch-3.2 too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962341849


   **[Test build #144939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144939/testReport)** for PR 34496 at commit [`776da3e`](https://github.com/apache/spark/commit/776da3e38b36ddea32f53e940db994406b27551e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962233403


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49411/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962359968


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144939/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sunchao closed pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
sunchao closed pull request #34496:
URL: https://github.com/apache/spark/pull/34496


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962210210


   **[Test build #144939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144939/testReport)** for PR 34496 at commit [`776da3e`](https://github.com/apache/spark/commit/776da3e38b36ddea32f53e940db994406b27551e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962263462


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49411/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962263462


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49411/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962254295


   Could you review this, @sunchao ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34496: [SPARK-37218][SQL][TEST] Parameterize `spark.sql.shuffle.partitions` in TPCDSQueryBenchmark

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34496:
URL: https://github.com/apache/spark/pull/34496#issuecomment-962359968


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144939/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org