You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 03:39:19 UTC
[PR] test(auth): deepen LoginDTO data and redaction coverage [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3270:
URL: https://github.com/apache/rocketmq-dashboard/pull/3270
## Summary
Extends the existing `LoginDTOTest` (1 to 3 tests) to pin down the login payload contract.
Added cases:
- `@Data` equality/hashCode cover both username and password: identical payloads are equal with the same hash, while a different password or a different username breaks equality;
- `toString` omits the password field entirely (neither the field name nor its value appears), extending the existing secret-redaction check to the field name itself.
## Why
The DTO is the login request boundary; equality semantics matter for tests and caching, and password redaction is a security invariant.
## Testing
`mvn -B test -Dtest=LoginDTOTest` — 3/3 pass; checkstyle (validate) clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(auth): deepen LoginDTO data and redaction coverage [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3270: test(auth): deepen LoginDTO data and redaction coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org