You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2017/11/07 18:13:59 UTC
[3/3] incubator-impala git commit: IMPALA-6105: Clarify argument
order in single_node_perf_run
IMPALA-6105: Clarify argument order in single_node_perf_run
single_node_perf_run.py uses git_hash_A vs. git_hash_B, distinguish
them by their position in the command-line
arguments. single_node_perf_run.py calls report_benchmark_results.py,
which uses the "reference vs. input", distinguished by their
command-line flags. The output of report_benchmark_results.py uses
"{empty string} vs Base".
In the long run, I think it would be better to fix all three to use
the same terminology, but this comment hopefully adds clarity.
Change-Id: Ib236ce7e83dc193ef1382f6304444ce58759a639
Reviewed-on: http://gerrit.cloudera.org:8080/8470
Tested-by: Impala Public Jenkins
Reviewed-by: Jim Apple <jb...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/216642e2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/216642e2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/216642e2
Branch: refs/heads/master
Commit: 216642e28d2454f7078c2e19f84e91e63221ea3c
Parents: fe90867
Author: Jim Apple <jb...@apache.org>
Authored: Sat Nov 4 15:18:31 2017 -0700
Committer: Jim Apple <jb...@apache.org>
Committed: Tue Nov 7 16:16:09 2017 +0000
----------------------------------------------------------------------
bin/single_node_perf_run.py | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/216642e2/bin/single_node_perf_run.py
----------------------------------------------------------------------
diff --git a/bin/single_node_perf_run.py b/bin/single_node_perf_run.py
index b67f661..c49e8e0 100755
--- a/bin/single_node_perf_run.py
+++ b/bin/single_node_perf_run.py
@@ -22,7 +22,17 @@
#
# When one hash is given, measures the performance on the specified workloads.
# When two hashes are given, compares their performance. Output is in
-# $IMPALA_HOME/perf_results/latest.
+# $IMPALA_HOME/perf_results/latest. In the performance_result.txt file,
+# git_hash_A is referred to as the "Base" result. For example, if you run with
+# git_hash_A = aBad1dea... and git_hash_B = 8675309... the
+# performance_result.txt will say at the top:
+#
+# Run Description: "aBad1dea... vs 8675309..."
+#
+# The different queries will have their run time statistics in columns
+# "Avg(s)", "StdDev(%)", "BaseAvg(s)", "Base StdDev(%)". The first two refer
+# to git_hash_B, the second two refer to git_hash_A. The column "Delta(Avg)"
+# is negative if git_hash_B is faster and is positive if git_hash_A is faster.
#
# WARNING: This script will run git checkout. You should not touch the tree
# while the script is running. You should start the script from a clean git
@@ -266,7 +276,17 @@ def parse_options():
When one hash is given, measures the performance on the specified workloads.
When two hashes are given, compares their performance. Output is in
- $IMPALA_HOME/perf_results/latest.
+ $IMPALA_HOME/perf_results/latest. In the performance_result.txt file,
+ git_hash_A is referred to as the "Base" result. For example, if you run with
+ git_hash_A = aBad1dea... and git_hash_B = 8675309... the
+ performance_result.txt will say at the top:
+
+ Run Description: "aBad1dea... vs 8675309..."
+
+ The different queries will have their run time statistics in columns
+ "Avg(s)", "StdDev(%)", "BaseAvg(s)", "Base StdDev(%)". The first two refer
+ to git_hash_B, the second two refer to git_hash_A. The column "Delta(Avg)"
+ is negative if git_hash_B is faster and is positive if git_hash_A is faster.
WARNING: This script will run git checkout. You should not touch the tree
while the script is running. You should start the script from a clean git