You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rekhajoshm <gi...@git.apache.org> on 2016/06/01 20:54:18 UTC
[GitHub] flink pull request #2061: [FLINK-4000] Checkpoint dictionaries null after ta...
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/flink/pull/2061
[FLINK-4000] Checkpoint dictionaries null after taskmgr failures
Fix for exception during job restart after task mgr failure, at which point restoreState fails as checkpoint dictionaries can be null.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rekhajoshm/flink FLINK-4000
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2061.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2061
----
commit 1e1ce9efefccf5a5585be802af4200e9d1ae7a98
Author: Rekha Joshi <re...@gmail.com>
Date: 2016-06-01T20:03:50Z
Merge pull request #1 from apache/master
Apache Flink master pull
commit 88929dcd989c34c3232f29a96af1b32ec1315911
Author: Joshi <re...@gmail.com>
Date: 2016-06-01T20:56:52Z
[FLINK-4000] Checkpoint dictionaries null after taskmgr failures
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2061: [FLINK-4000] Checkpoint dictionaries null after taskmgr f...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm commented on the issue:
https://github.com/apache/flink/pull/2061
@asavartsov Ok. Please let me know how you propose to solve this? thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2061: [FLINK-4000] Checkpoint dictionaries null after taskmgr f...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm commented on the issue:
https://github.com/apache/flink/pull/2061
aha, in one of my intermediate runs had done just initializing idsProcessedButNotAcknowledged and retain pendingCheckpoints , but in last run changed it calling open() :-( . makes sense @asavartsov. closing. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2061: [FLINK-4000] Checkpoint dictionaries null after ta...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm closed the pull request at:
https://github.com/apache/flink/pull/2061
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2061: [FLINK-4000] Checkpoint dictionaries null after taskmgr f...
Posted by asavartsov <gi...@git.apache.org>.
Github user asavartsov commented on the issue:
https://github.com/apache/flink/pull/2061
Take a look at my pull request at https://github.com/apache/flink/pull/2062
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2061: [FLINK-4000] Checkpoint dictionaries null after taskmgr f...
Posted by asavartsov <gi...@git.apache.org>.
Github user asavartsov commented on the issue:
https://github.com/apache/flink/pull/2061
This kind of check is might be useless and probably wouldn't fix the issue. My debugging shows that the list `idsProcessedButNotAcknowledged` is null on recovery, not checkpoints itself. This list is initialized in `open` method, but somehow it doesn't get called in such scenario.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2061: [FLINK-4000] Checkpoint dictionaries null after taskmgr f...
Posted by asavartsov <gi...@git.apache.org>.
Github user asavartsov commented on the issue:
https://github.com/apache/flink/pull/2061
No, it does not make any sense and even makes things worse, sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2061: [FLINK-4000] Checkpoint dictionaries null after taskmgr f...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm commented on the issue:
https://github.com/apache/flink/pull/2061
I agree @asavartsov , that was a quick look and was working to reproduce.Does the updated make sense? thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---