[jira] [Commented] (SPARK-14164) Improve input layer validation of MultilayerPerceptronClassifier

["Dongjoon Hyun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-14164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213574#comment-15213574 ] 

Dongjoon Hyun commented on SPARK-14164:
---------------------------------------

Hi, [~mengxr].

Could you review this PR? It implements the previous TODO requirement and removes the old TODO comment.

> Improve input layer validation of MultilayerPerceptronClassifier
> ----------------------------------------------------------------
>
>                 Key: SPARK-14164
>                 URL: https://issues.apache.org/jira/browse/SPARK-14164
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>            Reporter: Dongjoon Hyun
>            Priority: Minor
>
> This issue improves an input layer validation and adds related testcases to MultilayerPerceptronClassifier.
> {code:title=MultilayerPerceptronClassifier.scala|borderStyle=solid}
> -    // TODO: how to check ALSO that all elements are greater than 0?
> -    ParamValidators.arrayLengthGt(1)
> +    (t: Array[Int]) => t.forall(ParamValidators.gt(0)) && t.length > 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org