[GitHub] [iceberg] wypoon edited a comment on pull request #2954: [Spark] Support building against both Spark 3.0 and Spark 3.1: follow-up

[GitBox <gi...@apache.org>]

wypoon edited a comment on pull request #2954:
URL: https://github.com/apache/iceberg/pull/2954#issuecomment-894717376


   @RussellSpitzer we have tests that hit rewrite delete, just not rewrite delete with distribution mode.
   In https://github.com/apache/iceberg/blob/ee7fe3833ebd7d4321cec43987094c9f5d9664fb/spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDelete.scala#L94-L96
   it is only if there is a distribution mode that we need to call RepartitionByExpression.
   As @coolderli is adding tests in #2911 for distribution mode, and those tests would trigger this, I didn't feel the need to add something.
   However, I would like to see this go into 0.12.0.
   Let me know what you think.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org