You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2015/11/05 09:42:47 UTC
[GitHub] cloudstack pull request: Fix some small UI bugs
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1034
Fix some small UI bugs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack ui-changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1034
----
commit 0cdca3137f80f9f3b4f4a4bbf7b6dc574cedb5c0
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-11-04T12:27:10Z
[UI] fix typo for user data field
commit b75a2d01dabffe24e5e18938730fa70548459367
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-11-04T12:29:06Z
[UI] Private Cloud VPC always shows 0 in Site-to-Site VPN, even when one is configured
commit 7fb94444cb323329f7c3b9095d23240e9e1a5d57
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-11-05T07:04:23Z
[UI] change the Icon for changing ACL's for a tier in a VPC
commit f4bfb9b713f43b3b0e1b42ef0f97ac1984e009c1
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-11-05T07:04:34Z
[UI] Network names are not being displayed in Infra » VRs » router » NICS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155389974
Thanks @ustcweizhou LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155309530
[UI] fix typo for user data field - verfied
verified password dialog change
[UI] Network names are not being displayed in Infra » VRs » router » NICS - Can you share more details about this? probably a screenshot? even without this change, I see network name in nics list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155375779
@ustcweizhou and what about the ACL button?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155383672
@wilderrodrigues Please see attachment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155153401
@wilderrodrigues did you remove the .gz files?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155386360
Thanks, @ustcweizhou ... this PR LGTM :+1:
@remibergsma, I believe it's ready to be merged.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1034#discussion_r44254960
--- Diff: ui/scripts/vpc.js ---
@@ -1507,7 +1507,9 @@
},
complete: function(args) {
if (args.password != null) {
- alert('Password of the VM is ' + args.password);
+ cloudStack.dialog.notice({
+ message: 'Password of the VM is ' + args.password
--- End diff --
This I like very much! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155005958
Based on the code a LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-154048544
+1 LGTM, just looked at the code, did not check the actual UI rendering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155152303
Ping @remibergsma @ustcweizhou
1. Deployed a DC with a KVM host
2. Created 1 VM under an Isolated Network
3. Create a single VPC with 1 tier, 1 Vm and 1 ACL
Screenshots:
But I cannot get the new replace ACL icon. Tried on Chroem, Safari, cleaning the cache and also installed FireFox and tried there. Got the same image:
@ustcweizhou: could you please give some hints on how to get it working and just put some screenshots as well? It would also be fine to give the breadcrumbs about how to have the changes you made appearing on our UI.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1034#discussion_r44337756
--- Diff: server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java ---
@@ -219,6 +219,7 @@ public DomainRouterResponse setDomainRouterResponse(DomainRouterResponse vrData,
nicResponse.setGateway(vr.getGateway());
nicResponse.setNetmask(vr.getNetmask());
nicResponse.setNetworkid(vr.getNetworkUuid());
+ nicResponse.setNetworkName(vr.getNetworkName());
--- End diff --
@ustcweizhou Just for my understanding: why do we need this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1034#discussion_r44015311
--- Diff: ui/scripts/vpc.js ---
@@ -4184,7 +4184,7 @@
// Get VPN gateways
$.ajax({
- url: createURL('listVpnGateways'),
+ url: createURL('listVpnGateways&listAll=true'),
async: false,
data: {
'vpcid': args.context.vpc[0].id
--- End diff --
Can you put all the args defined with the url itself in the data object (like vpcid is defined for example, you can add 'listAll': true)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155129605
Ping @ustcweizhou @remibergsma
Deploying DC with this PR now. Will submit tests in a moment.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix some small UI bugs
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-155352944
@remibergsma @karuturi
For the isolated network and shared network, the guest NIC of VR is listed at the top of NIC tab.
However, for VPC VR, the guest NICs are listed at the bottom of NIC tab, the network name is missing for VPC tiers.
Sorry the description of the commit was not clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---