Re: [PR] [AVRO-4157]: [C++] Add get_metadata api in DataFileReaderBase [avro]

["KalleOlaviNiemitalo (via GitHub)" <gi...@apache.org>]

KalleOlaviNiemitalo commented on code in PR #3412:
URL: https://github.com/apache/avro/pull/3412#discussion_r2160080819


##########
lang/c++/include/avro/DataFile.hh:
##########
@@ -306,6 +308,11 @@ public:
      * Return the last synchronization point before our current position.
      */
     int64_t previousSync() const;
+
+    /**
+     * Return avro's metadata
+     */
+    Metadata &metadata() { return metadata_; }

Review Comment:
   This seems like it could be `const` because it copies the whole std::map and the copy retains no reference to the original objects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org