You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2014/04/23 20:18:30 UTC
svn commit: r1589483 -
/hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
Author: liyin
Date: Wed Apr 23 18:18:30 2014
New Revision: 1589483
URL: http://svn.apache.org/r1589483
Log:
[Master] Make TestSplitLogManager more stable
Author: liyintang
Summary: The previous timeout is quite aggressive (100ms), which causes the test very unstable. The fix is relatively simple by increasing the timeout by one order of magnitude.
Test Plan: run through this test 10 times successfully
Reviewers: daviddeng, gauravm, rshroff
Reviewed By: rshroff
CC: hbase-dev@
Differential Revision: https://phabricator.fb.com/D1291647
Task ID: 3376834
Modified:
hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
Modified: hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java?rev=1589483&r1=1589482&r2=1589483&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java (original)
+++ hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java Wed Apr 23 18:18:30 2014
@@ -239,7 +239,7 @@ public class TestSplitLogManager {
slm = new SplitLogManager(zkw, conf, stopper, "dummy-master", null);
slm.finishInitialization();
- waitForCounter(tot_mgr_orphan_task_acquired, 0, 1, 100);
+ waitForCounter(tot_mgr_orphan_task_acquired, 0, 1, 1000);
Task task = slm.findOrCreateOrphanTask(tasknode);
assertTrue(task.isOrphan());
waitForCounter(tot_mgr_heartbeat, 0, 1, 100);
@@ -248,9 +248,9 @@ public class TestSplitLogManager {
assertTrue((task.last_update <= curt) &&
(task.last_update > (curt - 1000)));
LOG.info("waiting for manager to resubmit the orphan task");
- waitForCounter(tot_mgr_resubmit, 0, 1, to + 300);
+ waitForCounter(tot_mgr_resubmit, 0, 1, to + 3000);
assertTrue(task.isUnassigned());
- waitForCounter(tot_mgr_rescan, 0, 1, to + 100);
+ waitForCounter(tot_mgr_rescan, 0, 1, to + 1000);
}
@Test
@@ -266,7 +266,7 @@ public class TestSplitLogManager {
slm = new SplitLogManager(zkw, conf, stopper, "dummy-master", null);
slm.finishInitialization();
- waitForCounter(tot_mgr_orphan_task_acquired, 0, 1, 100);
+ waitForCounter(tot_mgr_orphan_task_acquired, 0, 1, 1000);
Task task = slm.findOrCreateOrphanTask(tasknode);
assertTrue(task.isOrphan());
assertTrue(task.isUnassigned());
@@ -429,7 +429,7 @@ public class TestSplitLogManager {
slm = new SplitLogManager(zkw, conf, stopper, "dummy-master", null);
slm.finishInitialization();
- waitForCounter(tot_mgr_orphan_task_acquired, 0, 1, 100);
+ waitForCounter(tot_mgr_orphan_task_acquired, 0, 1, 1000);
// submit another task which will stay in unassigned mode