You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/14 17:44:20 UTC
[GitHub] [airflow] vincbeck opened a new pull request, #24448: Convert the batch sample dag to system tests (AIP-47)
vincbeck opened a new pull request, #24448:
URL: https://github.com/apache/airflow/pull/24448
Convert the batch sample dag to system tests (AIP-47)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #24448: Convert the batch sample dag to system tests (AIP-47)
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #24448:
URL: https://github.com/apache/airflow/pull/24448#discussion_r899010332
##########
airflow/providers/amazon/aws/utils/utils.py:
##########
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Could this file like `helpers.py` or something like than.
Might be it is personal but `from airflow.providers.amazon.aws.utils.utils import <placeholder>` looks like that some stuff duplicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on pull request #24448: Convert the batch sample dag to system tests (AIP-47)
Posted by GitBox <gi...@apache.org>.
vincbeck commented on PR #24448:
URL: https://github.com/apache/airflow/pull/24448#issuecomment-1187632051
Thanks for the feedbacks! I just addressed them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #24448: Convert the batch sample dag to system tests (AIP-47)
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #24448:
URL: https://github.com/apache/airflow/pull/24448#discussion_r897324743
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -126,6 +134,7 @@ def __init__(
aws_conn_id: Optional[str] = None,
region_name: Optional[str] = None,
tags: Optional[dict] = None,
+ wait_for_completion: bool = True,
Review Comment:
Hi, I know that is just draft PR.
But would you like also add changes in the extra link conditional property
https://github.com/apache/airflow/blob/7d8a17b2107a962e1ffcdb22fc13e1d23a98fdb7/airflow/providers/amazon/aws/operators/batch.py#L104-L111
If `wait_for_completion` sets to `False` then there is no reason add `BatchJobDefinitionLink()` and `BatchJobQueueLink()` since it executed at `monitor_job` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24448: Convert the batch sample dag to system tests (AIP-47)
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24448:
URL: https://github.com/apache/airflow/pull/24448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24448: Convert the batch sample dag to system tests (AIP-47)
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24448:
URL: https://github.com/apache/airflow/pull/24448#discussion_r901162184
##########
airflow/providers/amazon/aws/utils/utils.py:
##########
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
It is. Agree. I hate utils name, I usually use "common" and then each "comon" part should use a very specific package explaining what it is for.
The "utils" and especially "utils.utils" says exactly NOTHING about what is going on there without actuallly looking what is in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org