You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/03/06 22:41:28 UTC
[jclouds-site] Exit on failed commands (#63)
Previously a failed jekyll command would continue to deploy the site
with the older site content.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds-site errexit
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/63
-- Commit Summary --
* Exit on failed commands
-- File Changes --
M deploy-site.sh (2)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/63.patch
https://github.com/jclouds/jclouds-site/pull/63.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63
Re: [jclouds-site] Exit on failed commands (#63)
Posted by Ignasi Barrera <no...@github.com>.
+1!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36941377
Re: [jclouds-site] Exit on failed commands (#63)
Posted by jclouds-commentator <no...@github.com>.
Go to http://8b52767bd942c3450ef4-adcd3eff2d683d2a83bb6954fe53c79b.r35.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36940967
Re: [jclouds-site] Exit on failed commands (#63)
Posted by Andrew Gaul <no...@github.com>.
> @@ -1,5 +1,7 @@
> #!/bin/sh
>
> +set -o errexit
Strongly prefer verbose shell options!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63/files#r10370516
Re: [jclouds-site] Exit on failed commands (#63)
Posted by Andrew Gaul <no...@github.com>.
Closed #63.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63
Re: [jclouds-site] Exit on failed commands (#63)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #214](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/214/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36940746
Re: [jclouds-site] Exit on failed commands (#63)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36959754
Re: [jclouds-site] Exit on failed commands (#63)
Posted by Andrew Phillips <no...@github.com>.
One minor comment, but otherwise +1 - looks good to me. Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63#issuecomment-36956505
Re: [jclouds-site] Exit on failed commands (#63)
Posted by Andrew Phillips <no...@github.com>.
> @@ -1,5 +1,7 @@
> #!/bin/sh
>
> +set -o errexit
[minor] Shorten to [`set -e`](http://unixhelp.ed.ac.uk/CGI/man-cgi?sh)?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63/files#r10369173
Re: [jclouds-site] Exit on failed commands (#63)
Posted by Everett Toews <no...@github.com>.
> @@ -1,5 +1,7 @@
> #!/bin/sh
>
> +set -o errexit
+1 to verbose shell options
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/63/files#r10371334