You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2011/01/29 18:15:15 UTC

DO NOT REPLY [Bug 50687] New: Zip task doesn't pack empty ".gitignore" files

https://issues.apache.org/bugzilla/show_bug.cgi?id=50687

           Summary: Zip task doesn't pack empty ".gitignore" files
           Product: Ant
           Version: 1.8.2
          Platform: PC
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Core tasks
        AssignedTo: notifications@ant.apache.org
        ReportedBy: evgenyg@gmail.com


If I download this file:
http://gradle.artifactoryonline.com/gradle/distributions/gradle-0.9.2-all.zip
and run the script below:

<project default="pack">
    <target name="pack">
        <unzip src      = "gradle-0.9.2-all.zip"
               dest     = "aaaa"/>
        <zip   destfile = "gradle-0.9.2-all-2.zip"
               basedir  = "aaaa"/>
    </target>
</project>

Comparing "gradle-0.9.2-all.zip" and "gradle-0.9.2-all-2.zip" I see how
".gitignore" files from "gradle-0.9.2-all.zip" are missing in
"gradle-0.9.2-all-2.zip".

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50687] Zip task doesn't pack empty ".gitignore" files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50687

--- Comment #3 from Stefan Bodewig <bo...@apache.org> 2011-01-30 02:51:50 EST ---
That's because the change applies to all tasks with the defaultexcludes
attribute
as well as fileset - it is documented at a higher level.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50687] Zip task doesn't pack empty ".gitignore" files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50687

--- Comment #4 from Evgeny Goldin <ev...@gmail.com> 2011-01-30 05:08:46 EST ---
I see. I updated my task and it works Ok now.

Can I ask why do you consider ".gitignore" files as default excludes? Those
files are essential parts of the project, much like any other source.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50687] Zip task doesn't pack empty ".gitignore" files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50687

--- Comment #2 from Evgeny Goldin <ev...@gmail.com> 2011-01-30 02:38:37 EST ---
Thanks, Stefan. I was looking in Zip documentation but saw no updates for
1.8.2.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50687] Zip task doesn't pack empty ".gitignore" files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50687

Jesse Glick <jg...@netbeans.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jglick@netbeans.org

--- Comment #5 from Jesse Glick <jg...@netbeans.org> 2011-01-31 10:25:01 EST ---
(In reply to comment #4)
> why do you consider ".gitignore" files as default excludes?

Because they serve no function once removed from the context of a Git
repository (.git/ subdir, also excluded). Same for .cvsignore, .hgignore, etc.:
inside an unversioned source tree created by unpacking a ZIP, it is impossible
to differentiate files which were originally versioned from build products.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50687] Zip task doesn't pack empty ".gitignore" files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50687

--- Comment #6 from Evgeny Goldin <ev...@gmail.com> 2011-02-01 19:25:50 EST ---
Thanks, Jesse!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 50687] Zip task doesn't pack empty ".gitignore" files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50687

Stefan Bodewig <bo...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME
         OS/Version|                            |All

--- Comment #1 from Stefan Bodewig <bo...@apache.org> 2011-01-30 01:56:59 EST ---
Starting with Ant 1.8.2 .gitignore is part of the list of default excludes.
<http://ant.apache.org/manual/dirtasks.html#defaultexcludes>

This is why you no longer find it inside the archive, you have to set
defaultexcludes="no" on your zip task.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.