[GitHub] [druid] nlippis commented on a diff in pull request #14010: Fix issues with null pointers on jobResponse

["nlippis (via GitHub)" <gi...@apache.org>]

nlippis commented on code in PR #14010:
URL: https://github.com/apache/druid/pull/14010#discussion_r1154906934


##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidKubernetesPeonClient.java:
##########
@@ -111,7 +111,8 @@ public JobResponse waitForJobCompletion(K8sTaskId taskId, long howLong, TimeUnit
                           unit
                       );
       if (job == null) {
-        return new JobResponse(job, PeonPhase.FAILED);
+        log.info("K8s job for task was not found %s", taskId);
+        return new JobResponse(null, PeonPhase.FAILED);

Review Comment:
   Though this is an improvement over the current NPE, if we do this then a status won't ever be recorded for the task and it may be attempted to be rerun.  We should report the status using the taskid passed into this function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org