You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/11/07 18:33:38 UTC
[GitHub] [phoenix] gokceni commented on a change in pull request #621:
PHOENIX-5562 Simplify detection of concurrent updates on data tables with
indexes
gokceni commented on a change in pull request #621: PHOENIX-5562 Simplify detection of concurrent updates on data tables with indexes
URL: https://github.com/apache/phoenix/pull/621#discussion_r343807333
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -131,8 +124,8 @@ public long getCount() {
return count;
}
- public long getLatestTimestamp() {
- return latestTimestamp;
+ public boolean isConcurrent() {
+ return concurrent;
Review comment:
Nit: We don't need a boolean. We can just return count > 1;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services