You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/25 02:46:04 UTC

[GitHub] [iotdb] SzyWilliam commented on a diff in pull request #7712: [IOTDB-4742] [Consensus] add new api: addNewNodeToExistedGroup

SzyWilliam commented on code in PR #7712:
URL: https://github.com/apache/iotdb/pull/7712#discussion_r1003944807


##########
consensus/src/main/java/org/apache/iotdb/consensus/ratis/RatisConsensus.java:
##########
@@ -151,8 +159,16 @@ public void start() throws IOException {
 
   @Override
   public void stop() throws IOException {
-    clientManager.close();
-    server.close();
+    addExecutor.shutdown();
+    try {
+      addExecutor.awaitTermination(5, TimeUnit.SECONDS);
+    } catch (InterruptedException e) {
+      logger.warn("{}: interrupted when shutting down add Executor", this);

Review Comment:
   I'll add the exception. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org