You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/07 09:19:20 UTC

[GitHub] [superset] samudurand opened a new issue #14520: Helm ExtraConfigs are not loaded

samudurand opened a new issue #14520:
URL: https://github.com/apache/superset/issues/14520


   The documentation mentions that extra configs can be added via Helm, especially to add data sources on startup. 
   ```
   extraConfigs:
     datasources-init.yaml: |
       databases:
       - allow_csv_upload: true
         allow_ctas: true
         allow_cvas: true
         database_name: example-db
         extra: "{\r\n    \"metadata_params\": {},\r\n    \"engine_params\": {},\r\n    \"\
           metadata_cache_timeout\": {},\r\n    \"schemas_allowed_for_csv_upload\": []\r\n\
           }"
         sqlalchemy_uri: example://example-db.local
         tables: []
   ```
   But the config loaded in the container are not loaded by Superset.
   To make sure of it , I put a badly formatted yaml in the file, but it didn't trigger any error in Superset startup.
   
   ### Expected results
   
   Superset starts with pre-configured datasources/databases.
   
   ### Actual results
   
   Nothing
   
   #### How to reproduce the bug
   
   Follow the docs and add an extra config file, with datasources, or even with just bad yaml. Nothing will happen when deploying to kubernetes.
   
   ### Environment
   
   Kubernetes
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] stefano-cherchi removed a comment on issue #14520: Helm ExtraConfigs are not loaded

Posted by GitBox <gi...@apache.org>.
stefano-cherchi removed a comment on issue #14520:
URL: https://github.com/apache/superset/issues/14520#issuecomment-840550105


   I've also been struggling with the same issue for two days now. 
   
   Some custom configurations provided through `--values <filename>` are applied, some others are completely ignored. E.g: 
   
   ```yaml
   postgresql:
     enabled: true/false
   ```
   
   or 
   
   ```yaml
   service:
     type: LoadBalancer/ClusterIP
     port: 8088
     annotations: {
       service.beta.kubernetes.io/aws-load-balancer-internal: "false"
     }
     loadBalancerIP: null
   ```
   
   are applied, while `postgresHost:`, `extraEnv:`, `extraSecretEnv:`, and others never make it to the env variables passed to the pods ( `$DB_HOST`, `$DB_USER`, `$REDIS_HOST`, etc).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] stefano-cherchi commented on issue #14520: Helm ExtraConfigs are not loaded

Posted by GitBox <gi...@apache.org>.
stefano-cherchi commented on issue #14520:
URL: https://github.com/apache/superset/issues/14520#issuecomment-840550105


   I've also been struggling with the same issue for two days now. 
   
   Some custom configurations provided through `--values <filename>` are applied, some others are completely ignored. E.g: 
   
   ```yaml
   postgresql:
     enabled: true/false
   ```
   
   or 
   
   ```yaml
   service:
     type: LoadBalancer/ClusterIP
     port: 8088
     annotations: {
       service.beta.kubernetes.io/aws-load-balancer-internal: "false"
     }
     loadBalancerIP: null
   ```
   
   are applied, while `postgresHost:`, `extraEnv:`, `extraSecretEnv:`, and others never make it to the env variables passed to the pods ( `$DB_HOST`, `$DB_USER`, `$REDIS_HOST`, etc).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] PeterHenell commented on issue #14520: Helm ExtraConfigs are not loaded

Posted by GitBox <gi...@apache.org>.
PeterHenell commented on issue #14520:
URL: https://github.com/apache/superset/issues/14520#issuecomment-900156150


   The sample values.yaml file is using the wrong filename in extraConfigs.
   
   Changing datasources-init.yaml to import_datasources.yaml solves the issue.
   
   ```
   extraConfigs:
     import_datasources.yaml: |
       databases:
       - allow_csv_upload: true
         allow_ctas: true
         allow_cvas: true
         database_name: example-db
         extra: "{\r\n    \"metadata_params\": {},\r\n    \"engine_params\": {},\r\n    \"\
           metadata_cache_timeout\": {},\r\n    \"schemas_allowed_for_csv_upload\": []\r\n\
           }"
         sqlalchemy_uri: example://example-db.local
         tables: []
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amal-v commented on issue #14520: Helm ExtraConfigs are not loaded

Posted by GitBox <gi...@apache.org>.
amal-v commented on issue #14520:
URL: https://github.com/apache/superset/issues/14520#issuecomment-839573602


   I am also facing the same issue. Trying to findout whether we need to mention this file in any other configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org