You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2024/09/04 01:24:55 UTC
[PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
kaka11chen opened a new pull request, #40347:
URL: https://github.com/apache/doris/pull/40347
## Proposed changes
Add these configurations to control it.
```
// log enable custom date time format
DEFINE_Bool(sys_log_enable_custom_date_time_format, "false");
// log custom date time format (https://en.cppreference.com/w/cpp/io/manip/put_time)
DEFINE_String(sys_log_custom_date_time_format, "%Y-%m-%d %H:%M:%S");
// log custom date time milliseconds format (fmt::format)
DEFINE_String(sys_log_custom_date_time_ms_format, ",{:03d}");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2333038494
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327748308
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327735683
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327874233
<details>
<summary>TPC-DS: <b>Total hot run time: 192727 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 573a67fe3b48369f845e9f3b4edc752325950037, data reload: false
query1 1283 884 881 881
query2 6337 2007 1936 1936
query3 10736 4096 4186 4096
query4 59973 25244 23202 23202
query5 5570 502 499 499
query6 419 173 169 169
query7 5769 293 285 285
query8 289 203 224 203
query9 8817 2495 2456 2456
query10 489 291 255 255
query11 17492 15161 15311 15161
query12 150 107 107 107
query13 1522 411 404 404
query14 11158 7392 7080 7080
query15 246 176 176 176
query16 7172 489 508 489
query17 1170 563 574 563
query18 1755 294 294 294
query19 279 157 143 143
query20 115 107 111 107
query21 210 107 103 103
query22 4743 4627 4698 4627
query23 34203 33473 33903 33473
query24 5954 2787 2791 2787
query25 482 379 380 379
query26 668 146 150 146
query27 1779 281 274 274
query28 3678 2055 2039 2039
query29 628 421 402 402
query30 243 154 155 154
query31 946 760 770 760
query32 82 51 54 51
query33 415 272 281 272
query34 855 483 468 468
query35 850 725 742 725
query36 1022 940 936 936
query37 153 92 85 85
query38 4026 3985 3873 3873
query39 1453 1408 1382 1382
query40 194 113 112 112
query41 45 44 43 43
query42 122 98 95 95
query43 508 469 460 460
query44 1123 740 741 740
query45 199 169 166 166
query46 1110 723 750 723
query47 1881 1802 1803 1802
query48 379 294 294 294
query49 752 418 425 418
query50 809 416 407 407
query51 7071 6980 6874 6874
query52 101 85 84 84
query53 253 172 173 172
query54 560 441 448 441
query55 76 73 75 73
query56 271 257 243 243
query57 1194 1100 1085 1085
query58 218 258 236 236
query59 2996 2839 2873 2839
query60 285 265 271 265
query61 103 97 101 97
query62 743 647 630 630
query63 225 181 182 181
query64 2850 672 684 672
query65 3196 3161 3167 3161
query66 683 331 338 331
query67 15258 15109 15146 15109
query68 2928 577 583 577
query69 401 286 277 277
query70 1185 1142 1127 1127
query71 357 272 259 259
query72 5784 3987 3717 3717
query73 742 335 329 329
query74 9239 8803 8864 8803
query75 3322 2607 2701 2607
query76 1443 970 953 953
query77 531 317 350 317
query78 9719 9615 9295 9295
query79 1080 528 530 528
query80 689 499 500 499
query81 546 240 236 236
query82 243 144 147 144
query83 167 150 148 148
query84 256 76 132 76
query85 683 286 273 273
query86 297 304 296 296
query87 4442 4308 4409 4308
query88 3252 2410 2292 2292
query89 383 284 291 284
query90 1744 184 189 184
query91 127 97 94 94
query92 56 47 48 47
query93 1046 529 532 529
query94 544 299 289 289
query95 348 243 251 243
query96 584 271 265 265
query97 3201 3065 3089 3065
query98 220 208 211 208
query99 1514 1263 1282 1263
Total cold run time: 303409 ms
Total hot run time: 192727 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2330878086
<details>
<summary>TPC-H: <b>Total hot run time: 38402 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e64706dd3c4014f48f32ecdafd87b7d9571d907, data reload: false
------ Round 1 ----------------------------------
q1 17630 4773 4353 4353
q2 2017 192 187 187
q3 11764 1017 1191 1017
q4 10530 770 746 746
q5 7757 2936 2864 2864
q6 233 142 144 142
q7 969 622 609 609
q8 9356 2117 2096 2096
q9 7191 6528 6560 6528
q10 7032 2237 2247 2237
q11 477 243 242 242
q12 397 227 229 227
q13 18073 3045 3081 3045
q14 293 243 240 240
q15 529 502 484 484
q16 599 503 521 503
q17 1011 715 663 663
q18 7391 6925 6896 6896
q19 1385 1092 1058 1058
q20 691 344 336 336
q21 4010 3036 2928 2928
q22 1108 1043 1001 1001
Total cold run time: 110443 ms
Total hot run time: 38402 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4539 4327 4285 4285
q2 379 271 272 271
q3 2904 2677 2705 2677
q4 2002 1736 1673 1673
q5 5697 5757 5885 5757
q6 231 133 133 133
q7 2236 1891 1800 1800
q8 3304 3479 3561 3479
q9 8871 8893 8839 8839
q10 3680 3419 3335 3335
q11 608 501 511 501
q12 870 667 720 667
q13 14371 3303 3298 3298
q14 338 285 275 275
q15 555 498 508 498
q16 644 568 566 566
q17 1858 1574 1529 1529
q18 8173 7912 7885 7885
q19 1749 1551 1541 1541
q20 2232 1926 1977 1926
q21 5687 5670 5427 5427
q22 1139 1114 1108 1108
Total cold run time: 72067 ms
Total hot run time: 57470 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #40347:
URL: https://github.com/apache/doris/pull/40347#discussion_r1743905527
##########
be/src/common/logconfig.cpp:
##########
@@ -49,21 +49,41 @@ static bool iequals(const std::string& a, const std::string& b) {
return true;
}
-void custom_prefix(std::ostream& s, const google::LogMessageInfo& l, void*) {
- // Add prefix "RuntimeLogger ".
- s << "RuntimeLogger ";
- // Same as in fe.log
- // The following is same as default log format. eg:
- // I20240605 15:25:15.677153 1763151 wal_manager.cpp:481] msg...
+// if custom_date_time_format = false, same format as in be.log
+// The following is same as default log format. eg:
+// I20240605 15:25:15.677153 1763151 wal_manager.cpp:481] msg...
+template <bool add_runtime_logger_prefix = false, bool custom_date_time_format = false>
+void custom_prefix(std::ostream& s, const google::LogMessageInfo& l, void* arg) {
+ if constexpr (add_runtime_logger_prefix) {
+ // Add prefix "RuntimeLogger ".
+ s << "RuntimeLogger ";
+ }
s << l.severity[0];
- s << std::setw(4) << 1900 + l.time.year();
- s << std::setw(2) << 1 + l.time.month();
- s << std::setw(2) << l.time.day();
- s << ' ';
- s << std::setw(2) << l.time.hour() << ':';
- s << std::setw(2) << l.time.min() << ':';
- s << std::setw(2) << l.time.sec() << ".";
- s << std::setw(6) << l.time.usec();
+
+ // Add a space if custom_date_time_format.
+ if constexpr (custom_date_time_format) {
+ s << ' ';
Review Comment:
Why need a space here?
##########
be/src/common/logconfig.cpp:
##########
@@ -49,21 +49,41 @@ static bool iequals(const std::string& a, const std::string& b) {
return true;
}
-void custom_prefix(std::ostream& s, const google::LogMessageInfo& l, void*) {
- // Add prefix "RuntimeLogger ".
- s << "RuntimeLogger ";
- // Same as in fe.log
- // The following is same as default log format. eg:
- // I20240605 15:25:15.677153 1763151 wal_manager.cpp:481] msg...
+// if custom_date_time_format = false, same format as in be.log
+// The following is same as default log format. eg:
+// I20240605 15:25:15.677153 1763151 wal_manager.cpp:481] msg...
+template <bool add_runtime_logger_prefix = false, bool custom_date_time_format = false>
+void custom_prefix(std::ostream& s, const google::LogMessageInfo& l, void* arg) {
+ if constexpr (add_runtime_logger_prefix) {
+ // Add prefix "RuntimeLogger ".
+ s << "RuntimeLogger ";
+ }
s << l.severity[0];
- s << std::setw(4) << 1900 + l.time.year();
- s << std::setw(2) << 1 + l.time.month();
- s << std::setw(2) << l.time.day();
- s << ' ';
- s << std::setw(2) << l.time.hour() << ':';
- s << std::setw(2) << l.time.min() << ':';
- s << std::setw(2) << l.time.sec() << ".";
- s << std::setw(6) << l.time.usec();
+
+ // Add a space if custom_date_time_format.
+ if constexpr (custom_date_time_format) {
+ s << ' ';
+ }
+
+ std::tm tm_time = {};
+ tm_time.tm_year = l.time.year();
+ tm_time.tm_mon = l.time.month();
+ tm_time.tm_mday = l.time.day();
+ tm_time.tm_hour = l.time.hour();
+ tm_time.tm_min = l.time.min();
+ tm_time.tm_sec = l.time.sec();
+
+ if constexpr (custom_date_time_format) {
+ s << std::put_time(&tm_time, config::sys_log_custom_date_time_format.c_str());
+ if (!config::sys_log_custom_date_time_ms_format.empty()) {
+ s << fmt::format(config::sys_log_custom_date_time_ms_format,
+ l.time.usec() / 1000); // 确保毫秒为三位数字
Review Comment:
English comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327729386
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2328749550
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329631791
TeamCity be ut coverage result:
Function Coverage: 36.84% (9394/25497)
Line Coverage: 28.28% (77464/273938)
Region Coverage: 27.67% (39963/144453)
Branch Coverage: 24.31% (20335/83652)
Coverage Report: http://coverage.selectdb-in.cc/coverage/40fe19eb723a160277488b9281aa07c7a5e36324_40fe19eb723a160277488b9281aa07c7a5e36324/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327788042
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329436932
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329606762
<details>
<summary>TPC-H: <b>Total hot run time: 38271 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 40fe19eb723a160277488b9281aa07c7a5e36324, data reload: false
------ Round 1 ----------------------------------
q1 18155 5462 4360 4360
q2 2032 183 174 174
q3 11431 971 1109 971
q4 10365 756 761 756
q5 7761 2902 2849 2849
q6 234 139 135 135
q7 975 609 613 609
q8 9334 2122 2123 2122
q9 7264 6585 6613 6585
q10 7030 2240 2225 2225
q11 479 253 241 241
q12 403 227 227 227
q13 18942 3100 3114 3100
q14 289 237 232 232
q15 527 493 485 485
q16 604 504 525 504
q17 1031 655 651 651
q18 7443 6758 6877 6758
q19 1446 1046 975 975
q20 720 338 340 338
q21 3920 2975 3002 2975
q22 1090 999 1027 999
Total cold run time: 111475 ms
Total hot run time: 38271 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4437 4385 4367 4367
q2 381 276 277 276
q3 2919 2697 2685 2685
q4 1933 1649 1708 1649
q5 5686 5706 5772 5706
q6 230 132 134 132
q7 2270 1839 1850 1839
q8 3321 3546 3517 3517
q9 8789 8815 8799 8799
q10 3657 3670 3321 3321
q11 619 530 506 506
q12 887 668 690 668
q13 14394 3250 3311 3250
q14 323 277 281 277
q15 553 496 491 491
q16 622 576 586 576
q17 1854 1559 1564 1559
q18 8174 7880 7868 7868
q19 1775 1564 1481 1481
q20 2160 1936 1955 1936
q21 5684 5569 5353 5353
q22 1124 1089 1090 1089
Total cold run time: 71792 ms
Total hot run time: 57345 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2330910859
TeamCity be ut coverage result:
Function Coverage: 36.83% (9394/25503)
Line Coverage: 28.26% (77427/273972)
Region Coverage: 27.66% (39965/144478)
Branch Coverage: 24.31% (20338/83674)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9e64706dd3c4014f48f32ecdafd87b7d9571d907_9e64706dd3c4014f48f32ecdafd87b7d9571d907/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329627051
<details>
<summary>TPC-DS: <b>Total hot run time: 192834 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 40fe19eb723a160277488b9281aa07c7a5e36324, data reload: false
query1 1241 899 872 872
query2 6443 1999 1914 1914
query3 10610 4035 3901 3901
query4 59426 23846 23216 23216
query5 5397 509 507 507
query6 399 165 170 165
query7 5762 295 288 288
query8 297 211 222 211
query9 8753 2456 2426 2426
query10 468 292 271 271
query11 18195 15094 15480 15094
query12 157 103 101 101
query13 1548 409 417 409
query14 11368 7713 7663 7663
query15 229 192 188 188
query16 7516 422 462 422
query17 1135 587 597 587
query18 1879 303 286 286
query19 292 152 144 144
query20 125 110 108 108
query21 205 110 114 110
query22 4773 4529 4639 4529
query23 34367 33446 33280 33280
query24 5988 2899 2906 2899
query25 522 376 377 376
query26 679 160 156 156
query27 1771 282 276 276
query28 3743 2056 2030 2030
query29 650 399 404 399
query30 235 156 148 148
query31 915 751 746 746
query32 86 52 56 52
query33 443 289 298 289
query34 876 494 483 483
query35 830 733 719 719
query36 1058 939 937 937
query37 151 92 94 92
query38 3961 3858 3921 3858
query39 1527 1420 1381 1381
query40 198 122 119 119
query41 49 47 47 47
query42 122 101 98 98
query43 530 500 497 497
query44 1079 750 774 750
query45 202 166 214 166
query46 1096 735 711 711
query47 1893 1771 1815 1771
query48 376 293 291 291
query49 755 432 436 432
query50 818 420 414 414
query51 7154 6878 6857 6857
query52 97 86 85 85
query53 252 176 184 176
query54 569 453 449 449
query55 74 77 75 75
query56 276 261 266 261
query57 1213 1070 1063 1063
query58 223 233 251 233
query59 3224 2856 2799 2799
query60 287 282 272 272
query61 104 139 96 96
query62 736 629 627 627
query63 221 185 184 184
query64 2572 677 656 656
query65 3227 3182 3172 3172
query66 674 351 335 335
query67 15351 15164 15336 15164
query68 2943 568 614 568
query69 398 286 289 286
query70 1162 1154 1099 1099
query71 363 279 282 279
query72 5291 4031 4021 4021
query73 741 319 319 319
query74 9173 8809 8862 8809
query75 3387 2689 2670 2670
query76 1520 998 1025 998
query77 554 328 318 318
query78 9689 8968 8954 8954
query79 1039 538 534 534
query80 708 521 508 508
query81 470 241 230 230
query82 236 146 149 146
query83 178 148 154 148
query84 255 83 73 73
query85 673 284 276 276
query86 330 296 289 289
query87 4390 4335 4200 4200
query88 2919 2302 2325 2302
query89 392 286 289 286
query90 1934 193 194 193
query91 143 109 174 109
query92 58 48 50 48
query93 1049 514 521 514
query94 710 294 297 294
query95 320 252 248 248
query96 584 262 261 261
query97 3244 3083 3149 3083
query98 224 200 209 200
query99 1491 1326 1238 1238
Total cold run time: 303960 ms
Total hot run time: 192834 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329636768
<details>
<summary>ClickBench: <b>Total hot run time: 32.91 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 40fe19eb723a160277488b9281aa07c7a5e36324, data reload: false
query1 0.05 0.04 0.05
query2 0.08 0.04 0.04
query3 0.22 0.05 0.05
query4 1.68 0.08 0.08
query5 0.51 0.50 0.50
query6 1.13 0.72 0.72
query7 0.02 0.02 0.01
query8 0.04 0.04 0.05
query9 0.54 0.47 0.48
query10 0.55 0.54 0.55
query11 0.16 0.11 0.11
query12 0.15 0.13 0.13
query13 0.60 0.59 0.58
query14 2.04 2.06 2.08
query15 0.93 0.82 0.82
query16 0.37 0.38 0.37
query17 1.01 1.00 1.00
query18 0.21 0.20 0.20
query19 1.93 1.88 1.75
query20 0.02 0.01 0.01
query21 15.42 0.67 0.67
query22 3.81 5.90 2.92
query23 18.31 1.40 1.27
query24 2.13 0.25 0.21
query25 0.16 0.08 0.08
query26 0.27 0.19 0.18
query27 0.07 0.08 0.07
query28 13.26 1.01 1.01
query29 12.65 3.37 3.32
query30 0.24 0.05 0.06
query31 2.88 0.40 0.38
query32 3.27 0.47 0.50
query33 2.98 3.05 2.99
query34 17.03 4.32 4.42
query35 4.46 4.51 4.41
query36 0.66 0.46 0.46
query37 0.18 0.16 0.14
query38 0.15 0.15 0.15
query39 0.05 0.04 0.04
query40 0.16 0.12 0.14
query41 0.10 0.05 0.05
query42 0.05 0.04 0.05
query43 0.05 0.04 0.04
Total cold run time: 110.58 s
Total hot run time: 32.91 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327729135
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329479011
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327863986
<details>
<summary>TPC-H: <b>Total hot run time: 38291 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 573a67fe3b48369f845e9f3b4edc752325950037, data reload: false
------ Round 1 ----------------------------------
q1 17625 5296 4376 4376
q2 2019 202 171 171
q3 11781 946 1087 946
q4 10517 751 675 675
q5 7742 2866 2834 2834
q6 233 139 139 139
q7 976 609 608 608
q8 9347 2108 2091 2091
q9 7261 6542 6581 6542
q10 6996 2277 2225 2225
q11 471 251 242 242
q12 401 221 227 221
q13 17790 3097 3095 3095
q14 291 228 225 225
q15 526 494 481 481
q16 593 499 495 495
q17 988 780 739 739
q18 7291 6832 6761 6761
q19 1386 1007 993 993
q20 699 335 334 334
q21 3945 3157 3088 3088
q22 1099 1010 1023 1010
Total cold run time: 109977 ms
Total hot run time: 38291 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4387 4273 4316 4273
q2 369 285 259 259
q3 2892 2641 2638 2638
q4 1999 1723 1664 1664
q5 5682 5669 5779 5669
q6 233 140 141 140
q7 2270 1856 1773 1773
q8 3346 3420 3497 3420
q9 8866 8936 8881 8881
q10 3537 3369 3404 3369
q11 606 513 533 513
q12 821 622 687 622
q13 14715 3279 3295 3279
q14 310 277 280 277
q15 555 507 503 503
q16 626 570 591 570
q17 1871 1565 1561 1561
q18 8229 7934 7831 7831
q19 1786 1623 1602 1602
q20 2124 1940 1906 1906
q21 5903 5569 5486 5486
q22 1115 1050 1053 1050
Total cold run time: 72242 ms
Total hot run time: 57286 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2330902472
<details>
<summary>TPC-DS: <b>Total hot run time: 194078 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e64706dd3c4014f48f32ecdafd87b7d9571d907, data reload: false
query1 1266 876 925 876
query2 6388 1874 1896 1874
query3 10710 3944 4039 3944
query4 59783 24958 23147 23147
query5 5328 498 511 498
query6 416 174 156 156
query7 5775 310 291 291
query8 322 219 218 218
query9 9167 2463 2451 2451
query10 496 288 261 261
query11 17957 15120 15188 15120
query12 158 107 102 102
query13 1586 406 402 402
query14 11119 7642 7417 7417
query15 237 187 189 187
query16 7228 490 520 490
query17 1134 567 567 567
query18 1917 306 300 300
query19 294 149 159 149
query20 119 114 110 110
query21 208 114 104 104
query22 4681 4424 4573 4424
query23 34360 33409 33360 33360
query24 5951 3070 2993 2993
query25 542 375 385 375
query26 670 154 154 154
query27 1750 271 271 271
query28 3847 2057 2037 2037
query29 687 411 404 404
query30 244 154 153 153
query31 982 758 763 758
query32 85 56 57 56
query33 480 293 292 292
query34 955 483 489 483
query35 854 719 709 709
query36 1068 956 957 956
query37 157 97 92 92
query38 4079 3886 3947 3886
query39 1472 1411 1393 1393
query40 208 117 115 115
query41 52 49 49 49
query42 115 99 99 99
query43 524 466 473 466
query44 1141 754 747 747
query45 199 166 168 166
query46 1174 806 779 779
query47 1886 1805 1826 1805
query48 397 309 306 306
query49 798 459 471 459
query50 887 415 427 415
query51 7007 6914 6899 6899
query52 100 88 90 88
query53 270 182 184 182
query54 575 466 461 461
query55 80 78 78 78
query56 294 299 275 275
query57 1189 1048 1080 1048
query58 240 261 245 245
query59 2902 2746 2710 2710
query60 307 286 280 280
query61 128 125 126 125
query62 766 668 656 656
query63 224 189 188 188
query64 2491 765 767 765
query65 3264 3145 3199 3145
query66 690 351 375 351
query67 15443 15276 15432 15276
query68 3468 604 586 586
query69 412 287 281 281
query70 1174 1132 1046 1046
query71 367 296 283 283
query72 6550 4180 4269 4180
query73 800 322 324 322
query74 9242 8773 8891 8773
query75 3488 2681 2681 2681
query76 1579 1139 1027 1027
query77 522 318 309 309
query78 10071 10672 9676 9676
query79 1226 551 529 529
query80 921 526 528 526
query81 569 232 235 232
query82 293 145 150 145
query83 191 156 154 154
query84 269 75 76 75
query85 704 319 277 277
query86 439 292 266 266
query87 4581 4311 4269 4269
query88 3021 2322 2300 2300
query89 385 284 290 284
query90 1929 195 186 186
query91 127 106 114 106
query92 68 50 49 49
query93 1094 535 532 532
query94 796 298 285 285
query95 351 256 257 256
query96 639 259 256 256
query97 3271 3091 3094 3091
query98 219 206 199 199
query99 1570 1275 1259 1259
Total cold run time: 308159 ms
Total hot run time: 194078 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329419214
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2333038534
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2330913414
<details>
<summary>ClickBench: <b>Total hot run time: 31.89 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9e64706dd3c4014f48f32ecdafd87b7d9571d907, data reload: false
query1 0.05 0.05 0.04
query2 0.07 0.04 0.04
query3 0.23 0.05 0.05
query4 1.68 0.08 0.08
query5 0.51 0.49 0.49
query6 1.12 0.73 0.73
query7 0.02 0.01 0.02
query8 0.05 0.05 0.05
query9 0.55 0.49 0.48
query10 0.54 0.56 0.55
query11 0.16 0.12 0.11
query12 0.15 0.12 0.13
query13 0.60 0.59 0.60
query14 2.02 2.03 2.12
query15 0.85 0.82 0.82
query16 0.36 0.37 0.36
query17 1.07 1.05 1.06
query18 0.21 0.20 0.20
query19 1.91 1.78 1.73
query20 0.01 0.00 0.01
query21 15.39 0.67 0.67
query22 4.62 7.36 1.69
query23 18.32 1.41 1.30
query24 2.15 0.23 0.21
query25 0.16 0.08 0.08
query26 0.27 0.18 0.18
query27 0.07 0.07 0.08
query28 13.17 1.03 0.99
query29 12.65 3.35 3.33
query30 0.24 0.06 0.05
query31 2.87 0.40 0.42
query32 3.22 0.48 0.48
query33 3.01 2.99 3.03
query34 17.13 4.41 4.46
query35 4.46 4.43 4.47
query36 0.66 0.49 0.50
query37 0.18 0.16 0.15
query38 0.15 0.15 0.15
query39 0.04 0.04 0.04
query40 0.17 0.12 0.13
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.04 0.04 0.04
Total cold run time: 111.29 s
Total hot run time: 31.89 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2330957687
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327878869
<details>
<summary>ClickBench: <b>Total hot run time: 31.67 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 573a67fe3b48369f845e9f3b4edc752325950037, data reload: false
query1 0.05 0.05 0.04
query2 0.08 0.04 0.04
query3 0.23 0.05 0.05
query4 1.67 0.11 0.09
query5 0.50 0.48 0.50
query6 1.13 0.72 0.72
query7 0.01 0.01 0.01
query8 0.05 0.04 0.05
query9 0.56 0.49 0.49
query10 0.55 0.54 0.54
query11 0.16 0.12 0.11
query12 0.14 0.12 0.12
query13 0.61 0.58 0.59
query14 2.02 2.06 2.11
query15 0.90 0.82 0.81
query16 0.37 0.39 0.37
query17 1.06 1.05 0.98
query18 0.22 0.20 0.20
query19 1.96 1.86 1.76
query20 0.01 0.01 0.01
query21 15.42 0.67 0.67
query22 5.14 7.22 1.43
query23 18.25 1.42 1.30
query24 2.11 0.23 0.22
query25 0.14 0.09 0.08
query26 0.26 0.18 0.18
query27 0.07 0.08 0.06
query28 13.24 1.02 1.00
query29 12.63 3.35 3.35
query30 0.24 0.06 0.05
query31 2.88 0.41 0.40
query32 3.23 0.49 0.49
query33 2.98 2.99 3.04
query34 16.96 4.44 4.42
query35 4.50 4.48 4.47
query36 0.66 0.51 0.47
query37 0.19 0.15 0.15
query38 0.15 0.15 0.15
query39 0.05 0.04 0.04
query40 0.16 0.13 0.12
query41 0.08 0.04 0.05
query42 0.06 0.05 0.05
query43 0.04 0.04 0.04
Total cold run time: 111.72 s
Total hot run time: 31.67 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327871921
TeamCity be ut coverage result:
Function Coverage: 36.85% (9395/25495)
Line Coverage: 28.27% (77451/273948)
Region Coverage: 27.68% (39988/144448)
Branch Coverage: 24.32% (20343/83646)
Coverage Report: http://coverage.selectdb-in.cc/coverage/573a67fe3b48369f845e9f3b4edc752325950037_573a67fe3b48369f845e9f3b4edc752325950037/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2330723295
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on code in PR #40347:
URL: https://github.com/apache/doris/pull/40347#discussion_r1744697576
##########
be/src/common/logconfig.cpp:
##########
@@ -49,21 +49,41 @@ static bool iequals(const std::string& a, const std::string& b) {
return true;
}
-void custom_prefix(std::ostream& s, const google::LogMessageInfo& l, void*) {
- // Add prefix "RuntimeLogger ".
- s << "RuntimeLogger ";
- // Same as in fe.log
- // The following is same as default log format. eg:
- // I20240605 15:25:15.677153 1763151 wal_manager.cpp:481] msg...
+// if custom_date_time_format = false, same format as in be.log
+// The following is same as default log format. eg:
+// I20240605 15:25:15.677153 1763151 wal_manager.cpp:481] msg...
+template <bool add_runtime_logger_prefix = false, bool custom_date_time_format = false>
+void custom_prefix(std::ostream& s, const google::LogMessageInfo& l, void* arg) {
+ if constexpr (add_runtime_logger_prefix) {
+ // Add prefix "RuntimeLogger ".
+ s << "RuntimeLogger ";
+ }
s << l.severity[0];
- s << std::setw(4) << 1900 + l.time.year();
- s << std::setw(2) << 1 + l.time.month();
- s << std::setw(2) << l.time.day();
- s << ' ';
- s << std::setw(2) << l.time.hour() << ':';
- s << std::setw(2) << l.time.min() << ':';
- s << std::setw(2) << l.time.sec() << ".";
- s << std::setw(6) << l.time.usec();
+
+ // Add a space if custom_date_time_format.
+ if constexpr (custom_date_time_format) {
+ s << ' ';
Review Comment:
easy to parse date time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327798402
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2327753524
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #40347:
URL: https://github.com/apache/doris/pull/40347#issuecomment-2329465427
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](be-logger) Support custom date time format functionality in be log. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #40347:
URL: https://github.com/apache/doris/pull/40347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org