[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #18744: [v1.x] add linalg large matrix tests

[GitBox <gi...@apache.org>]

access2rohit commented on a change in pull request #18744:
URL: https://github.com/apache/incubator-mxnet/pull/18744#discussion_r459754090



##########
File path: tests/nightly/test_large_array.py
##########
@@ -1168,6 +1169,83 @@ def check_correctness(mxnet_op, numpy_op, atol=1e-3):
     check_binary_broadcast()
 
 
+def test_linalg():
+    def get_large_identity_mat():
+        A = nd.zeros((LARGE_SQ_X, LARGE_SQ_X))
+        for i in range(LARGE_SQ_X):
+            A[i,i] = 1
+        return A
+
+    def batchify(A):
+        A_np = A.asnumpy()
+        B = nd.array([A_np, A_np])

Review comment:
       @mseth10  and @Zha0q1  atleast run it for 2 batches. (2,70k,70k) would be better




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org