You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ffbin <gi...@git.apache.org> on 2015/08/03 10:21:54 UTC
[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/972
[FLINK-2465] Fix SocketClientSink closeConnection function memory leak
When closeConnection, should call dataOutputStream.close() instead of dataOutputStream.flush() because close() will call flush() first and then releases any system resources associated with this stream. Only call dataOutputStream.flush() cause memory leak.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK_2465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #972
----
commit a5222a5af269931ce0c641886002fda42e916733
Author: ffbin <86...@qq.com>
Date: 2015-08-03T07:50:26Z
Fix [FLINK-2465] SocketClientSink closeConnection function has memory leak
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/972#issuecomment-127182452
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the pull request:
https://github.com/apache/flink/pull/972#issuecomment-128853048
@StephanEwen
As we know, Flink's memory management is a significant feature to control very precisely how much memory used for improving system efficiency.(This is also why Spark 1.5 is working Tungsten project for it).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/972#issuecomment-127182565
BTW: All of these things are not memory leaks. Java always closes the streams when the objects are garbage collected.
It is simply good practice to close them as early as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2465] Fix SocketClientSink closeConnect...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/972#issuecomment-129491567
Agreed, it is good to fix these things, that's why I merge them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---