You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/09/26 08:33:00 UTC
[GitHub] [submarine] jeff-901 opened a new pull request #758: SUBMARINE-1036. Can't import submarine in notebook
jeff-901 opened a new pull request #758:
URL: https://github.com/apache/submarine/pull/758
### What is this PR for?
pip install submarine after conda activate. And remove pip install mlflow and boto3 in dockerfile, because it is in the dependency of submarine-sdk.
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1036
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #758: SUBMARINE-1036. Can't import submarine in notebook
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #758:
URL: https://github.com/apache/submarine/pull/758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on a change in pull request #758: SUBMARINE-1036. Can't import submarine in notebook
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on a change in pull request #758:
URL: https://github.com/apache/submarine/pull/758#discussion_r718079514
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
# Add DeepFM example into notebook
RUN cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \
cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \
rm submarine -rf
-# Install mlflow & minio dependencies
-RUN pip install boto3==1.17.58 mlflow==1.15.0
-
# Install latest stable qlib
Review comment:
@pingsutw
I think qlib can be removed.
What do you think?
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
Review comment:
redundant space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #758: SUBMARINE-1036. Can't import submarine in notebook
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #758:
URL: https://github.com/apache/submarine/pull/758#discussion_r718166434
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
# Add DeepFM example into notebook
RUN cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \
cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \
rm submarine -rf
-# Install mlflow & minio dependencies
-RUN pip install boto3==1.17.58 mlflow==1.15.0
-
# Install latest stable qlib
Review comment:
We use `qlib` in the notebook example.
https://github.com/apache/submarine/blob/6265879ed6482fafcbc278d82ef6416b61377407/dev-support/docker-images/jupyter/Dockerfile#L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #758: SUBMARINE-1036. Can't import submarine in notebook
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #758:
URL: https://github.com/apache/submarine/pull/758#discussion_r718166434
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
# Add DeepFM example into notebook
RUN cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \
cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \
rm submarine -rf
-# Install mlflow & minio dependencies
-RUN pip install boto3==1.17.58 mlflow==1.15.0
-
# Install latest stable qlib
Review comment:
We use `qlib` in the notebook example.
https://github.com/apache/submarine/blob/6265879ed6482fafcbc278d82ef6416b61377407/dev-support/docker-images/jupyter/Dockerfile#L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] lowc1012 commented on a change in pull request #758: SUBMARINE-1036. Can't import submarine in notebook
Posted by GitBox <gi...@apache.org>.
lowc1012 commented on a change in pull request #758:
URL: https://github.com/apache/submarine/pull/758#discussion_r718079514
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
# Add DeepFM example into notebook
RUN cp submarine/submarine-sdk/pysubmarine/example/submarine_experiment_sdk.ipynb $HOME && \
cp -r submarine/submarine-sdk/pysubmarine/example/{data,deepfm_example.ipynb,deepfm.json} $HOME && \
rm submarine -rf
-# Install mlflow & minio dependencies
-RUN pip install boto3==1.17.58 mlflow==1.15.0
-
# Install latest stable qlib
Review comment:
@pingsutw
I think qlib can be removed.
What do you think?
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
Review comment:
redundant space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on a change in pull request #758: SUBMARINE-1036. Can't import submarine in notebook
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on a change in pull request #758:
URL: https://github.com/apache/submarine/pull/758#discussion_r718088937
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
Review comment:
Thanks. I will delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on a change in pull request #758: SUBMARINE-1036. Can't import submarine in notebook
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on a change in pull request #758:
URL: https://github.com/apache/submarine/pull/758#discussion_r718088937
##########
File path: dev-support/docker-images/jupyter/Dockerfile
##########
@@ -94,21 +94,20 @@ RUN wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA
conda clean --all -f -y && \
rm -rf /home/$NB_USER/.cache/yarn
+RUN conda init bash
# Install latest sumbarine python sdk and notebook
-RUN git clone https://github.com/apache/submarine && \
- pip install -e submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
+RUN source ~/.bashrc && conda activate && \
+ git clone https://github.com/apache/submarine && \
+ pip install submarine/submarine-sdk/pysubmarine[tf,pytorch] && \
conda install nodejs && \
conda install -c conda-forge jupyterlab jupyterlab-git && \
- jupyter lab build
+ jupyter lab build
Review comment:
Thanks. I will delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org