You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/04 18:30:27 UTC

[GitHub] [doris] AshinGau opened a new pull request, #10602: [feature-wip](multi-catalog)(followup) federation query failed

AshinGau opened a new pull request, #10602:
URL: https://github.com/apache/doris/pull/10602

   # Proposed changes
   
   ## Problem Summary:
   Fix https://github.com/apache/doris/pull/10521, multi-catalog query failed for two reasons:
   1. The `SelectStmt` does not get the correct catalog.
   2. External table should have three level aliases.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (No)
   3. Has unit tests been added: (No)
   4. Has document been added or modified: (No)
   5. Does it need to update dependencies: (No)
   6. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10602: [feature-wip](multi-catalog)(fix) federation query failed

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10602:
URL: https://github.com/apache/doris/pull/10602#issuecomment-1178415695

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman commented on a diff in pull request #10602: [feature-wip](multi-catalog)(fix) federation query failed

Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10602:
URL: https://github.com/apache/doris/pull/10602#discussion_r913326561


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java:
##########
@@ -680,7 +680,7 @@ public TableRef resolveTableRef(TableRef tableRef) throws AnalysisException {
         // which may not be the same as the user's reference to the table name, causing the table name not to be found
         // in registerColumnRef(). So here the tblName is constructed using tableName.getTbl()
         // instead of table.getName().
-        TableName tblName = new TableName(tableName.getDb(), tableName.getTbl());
+        TableName tblName = new TableName(tableName.getCtl(), tableName.getDb(), tableName.getTbl());

Review Comment:
   I think we should disable the constructor of `TableName` with 2 params.
   That is very error-prone



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman merged pull request #10602: [feature-wip](multi-catalog)(fix) federation query failed

Posted by GitBox <gi...@apache.org>.
morningman merged PR #10602:
URL: https://github.com/apache/doris/pull/10602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10602: [feature-wip](multi-catalog)(fix) federation query failed

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10602:
URL: https://github.com/apache/doris/pull/10602#issuecomment-1175833127

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10602: [feature-wip](multi-catalog)(fix) federation query failed

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10602:
URL: https://github.com/apache/doris/pull/10602#issuecomment-1175851626

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #10602: [feature-wip](multi-catalog)(fix) federation query failed

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10602:
URL: https://github.com/apache/doris/pull/10602#issuecomment-1175833160

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org