You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/05/04 01:47:16 UTC
[kudu-CR] KUDU-2612: update Java client API to commit a transaction
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17393
Change subject: KUDU-2612: update Java client API to commit a transaction
......................................................................
KUDU-2612: update Java client API to commit a transaction
This patch updates the signature of the KuduTransaction::commit()
method to address recent feedback on the txn-related API. The idea is
to make the API easier to use, since txn.commit(false) looks a bit vague
and might be confusing as well.
In essence, the 'wait' parameter is gone and now there are two methods:
* KuduTransaction.commit()
* KuduTransaction.startCommit()
The former starts committing a multi-row transaction and waits for the
commit phase to finalize. The latter just starts the commit phase for
a multi-row transaction and returns, not awaiting for the commit phase
to finalize.
These changes mirror recent changes in the C++ client API.
Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
2 files changed, 87 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/17393/1
--
To view, visit http://gerrit.cloudera.org:8080/17393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
Gerrit-Change-Number: 17393
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2612: update Java client API to commit a transaction
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17393 )
Change subject: KUDU-2612: update Java client API to commit a transaction
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
Gerrit-Change-Number: 17393
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 May 2021 07:02:26 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612: update Java client API to commit a transaction
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17393 )
Change subject: KUDU-2612: update Java client API to commit a transaction
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
Gerrit-Change-Number: 17393
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 May 2021 03:41:00 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612: update Java client API to commit a transaction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17393
to look at the new patch set (#2).
Change subject: KUDU-2612: update Java client API to commit a transaction
......................................................................
KUDU-2612: update Java client API to commit a transaction
This patch updates the signature of the KuduTransaction::commit()
method to address recent feedback on the txn-related API. The idea is
to make the API easier to use, since txn.commit(false) looks a bit vague
and might be confusing as well.
In essence, the 'wait' parameter is gone and now there are two methods:
* KuduTransaction.commit()
* KuduTransaction.startCommit()
The former starts committing a multi-row transaction and waits for the
commit phase to finalize. The latter just starts the commit phase for
a multi-row transaction and returns, not awaiting for the commit phase
to finalize.
These changes mirror recent changes in the C++ client API.
Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
2 files changed, 87 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/17393/2
--
To view, visit http://gerrit.cloudera.org:8080/17393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
Gerrit-Change-Number: 17393
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612: update Java client API to commit a transaction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17393 )
Change subject: KUDU-2612: update Java client API to commit a transaction
......................................................................
KUDU-2612: update Java client API to commit a transaction
This patch updates the signature of the KuduTransaction::commit()
method to address recent feedback on the txn-related API. The idea is
to make the API easier to use, since txn.commit(false) looks a bit vague
and might be confusing as well.
In essence, the 'wait' parameter is gone and now there are two methods:
* KuduTransaction.commit()
* KuduTransaction.startCommit()
The former starts committing a multi-row transaction and waits for the
commit phase to finalize. The latter just starts the commit phase for
a multi-row transaction and returns, not awaiting for the commit phase
to finalize.
These changes mirror recent changes in the C++ client API.
Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
Reviewed-on: http://gerrit.cloudera.org:8080/17393
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
2 files changed, 87 insertions(+), 58 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8c48b4d375945649c48428401f09ec5c7cc8cb7
Gerrit-Change-Number: 17393
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)