[GitHub] [tvm-rfcs] tkonolige commented on pull request #88: [RFC] Add Commit Message Guideline

[GitBox <gi...@apache.org>]

tkonolige commented on PR #88:
URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1217226784

   @gromero I think I am getting a little confused at the difference between messages in the commits composing the PR and the final commit in main. To make things clearer, I think it would help to refer to to commit title and commit message as PR title and PR description, respectively. PR title and PR description are the things that the PR author and the reviewers will be discussing (which will become the commit title and message).
   
   To clarify, these guidelines do not apply to the individual commits (on the authors branch) that compose the PR?
   
   > i.e. they should copy text from the PR description, title and body.
   
   I think we should explicitly say that whoever is merging the PR needs to copy the description of the PR into the commit message (unless we have changed GitHub to do this automatically?). Having clear instructions (like how to copy formatting) for mergers would be really nice.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org