[GitHub] [beam] TheNeuralBit edited a comment on pull request #11917: [BEAM-8602] Use shadow configuration for remaining DirectRunner dependencies

[GitBox <gi...@apache.org>]

TheNeuralBit edited a comment on pull request #11917:
URL: https://github.com/apache/beam/pull/11917#issuecomment-638530705


   I grepped the build.gradle files to look for any other instances of adding the direct runner as a dependency dynamically, and couldn't find anything else:
   
   ```
   ❯ grep -iIrn "runners:direct-java" **/build.gradle | grep -v shadow
   build.gradle:154:  dependsOn ":runners:direct-java:needsRunnerTests"
   release/build.gradle:33:  dependsOn ":runners:direct-java:runQuickstartJavaDirect"
   release/build.gradle:38:  dependsOn ":runners:direct-java:runMobileGamingJavaDirect"
   runners/direct-java/build.gradle:154:// Generates :runners:direct-java:runQuickstartJavaDirect
   runners/direct-java/build.gradle:157:// Generates :runners:direct-java:runMobileGamingJavaDirect
   sdks/java/testing/load-tests/build.gradle:40:        : ":runners:direct-java")
   sdks/java/testing/load-tests/build.gradle:78:  // to not hardcode any runner other than :runners:direct-java
   sdks/java/testing/nexmark/build.gradle:35:        ?: ":runners:direct-java"
   sdks/java/testing/nexmark/build.gradle:85:  // to not hardcode any runner other than :runners:direct-java
   sdks/java/testing/nexmark/build.gradle:107://       Defaults to ":runners:direct-java"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org