You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/10/17 02:13:00 UTC
[jira] [Commented] (GEODE-5879) Use and enforce consistent gradle
declaration behavior
[ https://issues.apache.org/jira/browse/GEODE-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652852#comment-16652852 ]
ASF subversion and git services commented on GEODE-5879:
--------------------------------------------------------
Commit 89105618d7877cce23ffa7456ba97aec621c1160 in geode's branch refs/heads/develop from [~rhoughton]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8910561 ]
GEODE-5879 Enforces consistent syntax in gradle dependency declaration (#2611)
Always use a parentesis around the thing being depended on.
Do not space pad between configuration and parenthesis before dependency
Prefer single quote around the package names
Co-authored-by: Robert Houghton <rh...@pivotal.io>
Co-authored-by: Patrick Rhomberg <pr...@pivotal.io>
> Use and enforce consistent gradle declaration behavior
> ------------------------------------------------------
>
> Key: GEODE-5879
> URL: https://issues.apache.org/jira/browse/GEODE-5879
> Project: Geode
> Issue Type: Improvement
> Components: ci
> Reporter: Robert Houghton
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Gradle syntax is permissive about dependency declaration, unless exclusions are needed. Then the input must be in a parenthetical block before opening the closure. Fix this everywhere, and then use a spotless rule to make it consistent forever
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)