You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/02 18:42:05 UTC
[GitHub] [druid] suneet-s commented on a change in pull request #9294: SQL
join support for lookups.
suneet-s commented on a change in pull request #9294: SQL join support for lookups.
URL: https://github.com/apache/druid/pull/9294#discussion_r373822697
##########
File path: processing/src/main/java/org/apache/druid/segment/join/MapJoinableFactory.java
##########
@@ -36,7 +36,7 @@
private final Map<Class<? extends DataSource>, JoinableFactory> joinableFactories;
@Inject
- MapJoinableFactory(Map<Class<? extends DataSource>, JoinableFactory> joinableFactories)
+ public MapJoinableFactory(Map<Class<? extends DataSource>, JoinableFactory> joinableFactories)
Review comment:
does this need to be public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org