You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Dmitry Drozdov (JIRA)" <ji...@apache.org> on 2010/09/02 10:10:53 UTC
[jira] Created: (FELIX-2571) Make changes done via Configuration
Admin Service in web interface be persisted to the original config file in
etc folder
Make changes done via Configuration Admin Service in web interface be persisted to the original config file in etc folder
-------------------------------------------------------------------------------------------------------------------------
Key: FELIX-2571
URL: https://issues.apache.org/jira/browse/FELIX-2571
Project: Felix
Issue Type: Improvement
Components: Web Console
Reporter: Dmitry Drozdov
Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Make changes done via Configuration
Admin Service in web interface be persisted to the original config file in
etc folder
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905487#action_12905487 ]
Felix Meschberger commented on FELIX-2571:
------------------------------------------
I cannot tell about the design decision of that time (yet, I think it is equally wrong).
> Make changes done via Configuration Admin Service in web interface be persisted to the original config file in etc folder
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2571) Have fileinstall listen for
configuration changes and write them back to the config files
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-2571.
------------------------------------
Resolution: Fixed
Fix Version/s: fileinstall-3.1.0
utils-1.0.2
> Have fileinstall listen for configuration changes and write them back to the config files
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
> Assignee: Guillaume Nodet
> Fix For: utils-1.0.2, fileinstall-3.1.0
>
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2571) Have fileinstall listen for
configuration changes and write them back to the config files
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated FELIX-2571:
-----------------------------------
Assignee: Guillaume Nodet
Summary: Have fileinstall listen for configuration changes and write them back to the config files (was: Make changes done via Configuration Admin Service in web interface be persisted to the original config file in etc folder)
> Have fileinstall listen for configuration changes and write them back to the config files
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
> Assignee: Guillaume Nodet
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Have fileinstall listen for
configuration changes and write them back to the config files
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923944#action_12923944 ]
Felix Meschberger commented on FELIX-2571:
------------------------------------------
Ah, missed that. Sorry to have bothered ...
> Have fileinstall listen for configuration changes and write them back to the config files
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
> Assignee: Guillaume Nodet
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Make changes done via Configuration
Admin Service in web interface be persisted to the original config file in
etc folder
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905448#action_12905448 ]
Felix Meschberger commented on FELIX-2571:
------------------------------------------
I don't think it is the task of the web console to write something back to somewhere.
Rather -- probably -- the FileInstall tool should listen for configuration changes and write them back if appropriate.
Reason: The FileInstall module loads the config file and ingests it into the Configuration Admin service. So this module knows the connection between the file and the configuration. Thus this module is the only one being able to feed modified configuration back to files.
> Make changes done via Configuration Admin Service in web interface be persisted to the original config file in etc folder
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Dmitry Drozdov
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Make changes done via Configuration
Admin Service in web interface be persisted to the original config file in
etc folder
Posted by "Dmitry Drozdov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905482#action_12905482 ]
Dmitry Drozdov commented on FELIX-2571:
---------------------------------------
Looking at FELIX-1718 I can see that it was done in shell bundle, not in the fileinstall one.
So that was the bad design idea that time? :)
Should I move the issue to fileinstall component?
> Make changes done via Configuration Admin Service in web interface be persisted to the original config file in etc folder
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Reporter: Dmitry Drozdov
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Have fileinstall listen for
configuration changes and write them back to the config files
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923957#action_12923957 ]
Carsten Ziegeler commented on FELIX-2571:
-----------------------------------------
The code for writing the configurations introduced with FELIX-2513 is in the class coming from the ConfigAdmin which is embedded in FileInstall. It has methods for reading the configs (currently used) and for writing them back.
> Have fileinstall listen for configuration changes and write them back to the config files
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
> Assignee: Guillaume Nodet
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Have fileinstall listen for
configuration changes and write them back to the config files
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923870#action_12923870 ]
Guillaume Nodet commented on FELIX-2571:
----------------------------------------
I'm working on that, but I won't be able to have this behavior consistently as I don't have any code that could handle the new ".config" files with the extended syntax from felix config admin. So this will only work for ".cfg" files.
> Have fileinstall listen for configuration changes and write them back to the config files
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
> Assignee: Guillaume Nodet
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Have fileinstall listen for
configuration changes and write them back to the config files
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923897#action_12923897 ]
Guillaume Nodet commented on FELIX-2571:
----------------------------------------
I think i haven't explained myself very well.
FELIX-2513 introduced a new set of configurations which are based on file properties (as it was the case before), but using a different syntax (so it can't be read by java.util.properties correctly).
What I meant is that I don't have the code to write those configuration files back and keeping the comments and formatting, so those will be lost.
The behavior will be slightly different in these two cases, though only configurations managed by fileinstall will be written back.
> Have fileinstall listen for configuration changes and write them back to the config files
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
> Assignee: Guillaume Nodet
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2571) Have fileinstall listen for
configuration changes and write them back to the config files
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923880#action_12923880 ]
Felix Meschberger commented on FELIX-2571:
------------------------------------------
I think the FileInstall ConfigurationListener should really only write back configuration which has been created through FileInstall and not tamper with any other configurations, such as those created directly with Configuration Admin or through other agents (like Sling's JCR Install).
In this case, this "restriction" is probably exactly, how it should be.
> Have fileinstall listen for configuration changes and write them back to the config files
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
> Assignee: Guillaume Nodet
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2571) Make changes done via Configuration
Admin Service in web interface be persisted to the original config file in
etc folder
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated FELIX-2571:
-------------------------------------
Component/s: File Install
(was: Web Console)
Handing over to FileInstall for implementation.
> Make changes done via Configuration Admin Service in web interface be persisted to the original config file in etc folder
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: FELIX-2571
> URL: https://issues.apache.org/jira/browse/FELIX-2571
> Project: Felix
> Issue Type: Improvement
> Components: File Install
> Reporter: Dmitry Drozdov
>
> Same has been done for shell config:update command withinin FELIX-1718
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.