You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/20 08:59:03 UTC

[GitHub] [incubator-superset] villebro commented on a change in pull request #11998: fix: SIP-15 time_range_endpoints not using default option

villebro commented on a change in pull request #11998:
URL: https://github.com/apache/incubator-superset/pull/11998#discussion_r546346162



##########
File path: superset/config.py
##########
@@ -950,7 +950,7 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 # indefinite.
 SIP_15_ENABLED = True
 SIP_15_GRACE_PERIOD_END: Optional[date] = None  # exclusive
-SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["unknown", "inclusive"]
+SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["inclusive", "exclusive"]

Review comment:
       I'm surprised these are not in line with the comment in `utils`. I would be interested in hearing @john-bodley's thoughts on this change, as it looks like this is a bug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org