You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kevinjmh <gi...@git.apache.org> on 2019/01/08 07:50:56 UTC

[GitHub] carbondata pull request #3054: [CARBONDATA-3232] Add example and doc for all...

Github user kevinjmh commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3054#discussion_r245902021
  
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/util/ExampleUtils.scala ---
    @@ -30,13 +30,20 @@ object ExampleUtils {
           .getCanonicalPath
       val storeLocation: String = currentPath + "/target/store"
     
    -  def createCarbonSession(appName: String, workThreadNum: Int = 1): SparkSession = {
    +  def createCarbonSession (appName: String, workThreadNum: Int = 1,
    +      storePath: String = null): SparkSession = {
         val rootPath = new File(this.getClass.getResource("/").getPath
    -                            + "../../../..").getCanonicalPath
    -    val storeLocation = s"$rootPath/examples/spark2/target/store"
    +      + "../../../..").getCanonicalPath
    +
         val warehouse = s"$rootPath/examples/spark2/target/warehouse"
         val metaStoreDB = s"$rootPath/examples/spark2/target"
     
    +    val storeLocation = if (null != storePath) {
    +      storePath;
    --- End diff --
    
    no need for `;`


---